You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/09/06 09:48:40 UTC
[GitHub] [incubator-linkis] QuintinTao opened a new pull request, #3261: test case for spark executor
QuintinTao opened a new pull request, #3261:
URL: https://github.com/apache/incubator-linkis/pull/3261
test cases for spark executor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3261: test case for spark executor
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3261:
URL: https://github.com/apache/incubator-linkis/pull/3261#issuecomment-1237964584
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3261?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3261](https://codecov.io/gh/apache/incubator-linkis/pull/3261?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa9dc30) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/cdebd9e85e6d83e76548e890a7a7b18901afac7e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdebd9e) will **increase** coverage by `1.65%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3261 +/- ##
===============================================
+ Coverage 16.56% 18.22% +1.65%
- Complexity 1399 1457 +58
===============================================
Files 779 779
Lines 25382 25382
Branches 3602 3602
===============================================
+ Hits 4204 4625 +421
+ Misses 20629 20139 -490
- Partials 549 618 +69
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...engineplugin/spark/config/SparkConfiguration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvY29uZmlnL1NwYXJrQ29uZmlndXJhdGlvbi5zY2FsYQ==) | `93.75% <100.00%> (+93.75%)` | :arrow_up: |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `36.79% <0.00%> (-1.89%)` | :arrow_down: |
| [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `30.90% <0.00%> (-1.82%)` | :arrow_down: |
| [...r/engineplugin/python/executor/PythonSession.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9weXRob24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vcHl0aG9uL2V4ZWN1dG9yL1B5dGhvblNlc3Npb24uc2NhbGE=) | `58.41% <0.00%> (ø)` | |
| [.../linkis/engineplugin/spark/utils/EngineUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvdXRpbHMvRW5naW5lVXRpbHMuc2NhbGE=) | `3.44% <0.00%> (+3.44%)` | :arrow_up: |
| [...s/engineplugin/spark/mdq/MDQPreExecutionHook.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvbWRxL01EUVByZUV4ZWN1dGlvbkhvb2suc2NhbGE=) | `7.40% <0.00%> (+7.40%)` | :arrow_up: |
| [...n/spark/args/SparkPythonArgsPreExecutionHook.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvYXJncy9TcGFya1B5dGhvbkFyZ3NQcmVFeGVjdXRpb25Ib29rLnNjYWxh) | `9.30% <0.00%> (+9.30%)` | :arrow_up: |
| [...plugin/spark/args/SparkScalaPreExecutionHook.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvYXJncy9TcGFya1NjYWxhUHJlRXhlY3V0aW9uSG9vay5zY2FsYQ==) | `11.11% <0.00%> (+11.11%)` | :arrow_up: |
| [.../engineplugin/spark/mdq/MDQPostExecutionHook.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9lbmdpbmVwbHVnaW4vc3BhcmsvbWRxL01EUVBvc3RFeGVjdXRpb25Ib29rLnNjYWxh) | `15.00% <0.00%> (+15.00%)` | :arrow_up: |
| [...ache/spark/sql/execution/datasources/csv/UDF.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9leGVjdXRpb24vZGF0YXNvdXJjZXMvY3N2L1VERi5zY2FsYQ==) | `16.66% <0.00%> (+16.66%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-linkis/pull/3261/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] QuintinTao closed pull request #3261: Test case for spark executor
Posted by GitBox <gi...@apache.org>.
QuintinTao closed pull request #3261: Test case for spark executor
URL: https://github.com/apache/incubator-linkis/pull/3261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #3261: Test case for spark executor
Posted by GitBox <gi...@apache.org>.
peacewong commented on code in PR #3261:
URL: https://github.com/apache/incubator-linkis/pull/3261#discussion_r969201506
##########
linkis-engineconn-plugins/spark/pom.xml:
##########
@@ -377,6 +377,12 @@
<version>3.0.9</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.poi</groupId>
Review Comment:
Introduced in the linkis-storage module, is it necessary here?
##########
linkis-engineconn-plugins/spark/src/test/scala/org/apache/linkis/engineplugin/spark/config/TestSparkConfiguration.scala:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.linkis.engineplugin.spark.config
+
+import org.junit.jupiter.api.{Assertions, Test}
+
+class TestSparkConfiguration {
+
Review Comment:
It is recommended to remove the configuration test of the configuration, because it is common to modify the configuration parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org