You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Samisa Abeysinghe (JIRA)" <ax...@ws.apache.org> on 2005/05/25 07:33:51 UTC
[jira] Created: (AXISCPP-659) Move connection opening out of flushOutput method
Move connection opening out of flushOutput method
-------------------------------------------------
Key: AXISCPP-659
URL: http://issues.apache.org/jira/browse/AXISCPP-659
Project: Axis-C++
Type: Improvement
Components: Transport (axis3)
Versions: 1.5 Final
Reporter: Samisa Abeysinghe
Fix For: 1.6 Alpha
Connection opening should not be the responsibility of the flushOutput method. Rather it has to be an independent act.
When connection opening is within the flushOutput, it becomes harder to debug. Hence it is ideal to move this to out of flushOutput.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXISCPP-659) Move connection opening out of flushOutput method
Posted by "Samisa Abeysinghe (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-659?page=comments#action_66257 ]
Samisa Abeysinghe commented on AXISCPP-659:
-------------------------------------------
I think the best place where we could call Transport::openConnection is in ClientAxisEngine::invoke() method. I tried including it like the following inside invoke:
if (AXIS_SUCCESS != (Status = m_pSZ->setOutputStream (m_pSoap)))
break;
m_pSoap->openConnection();
m_pSZ->markEndOfStream();
So before calling markEndOfStream whuch calls Transport::flushOutput(), I open the connection. flushOutput will only other about writing to the stream, and not open the connection.
> Move connection opening out of flushOutput method
> -------------------------------------------------
>
> Key: AXISCPP-659
> URL: http://issues.apache.org/jira/browse/AXISCPP-659
> Project: Axis-C++
> Type: Improvement
> Components: Transport (axis3)
> Versions: 1.5 Final
> Reporter: Samisa Abeysinghe
> Assignee: Samisa Abeysinghe
> Fix For: 1.6 Alpha
>
> Connection opening should not be the responsibility of the flushOutput method. Rather it has to be an independent act.
> When connection opening is within the flushOutput, it becomes harder to debug. Hence it is ideal to move this to out of flushOutput.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (AXISCPP-659) Move connection opening out of flushOutput method
Posted by "Samisa Abeysinghe (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-659?page=all ]
Samisa Abeysinghe reassigned AXISCPP-659:
-----------------------------------------
Assign To: Samisa Abeysinghe
> Move connection opening out of flushOutput method
> -------------------------------------------------
>
> Key: AXISCPP-659
> URL: http://issues.apache.org/jira/browse/AXISCPP-659
> Project: Axis-C++
> Type: Improvement
> Components: Transport (axis3)
> Versions: 1.5 Final
> Reporter: Samisa Abeysinghe
> Assignee: Samisa Abeysinghe
> Fix For: 1.6 Alpha
>
> Connection opening should not be the responsibility of the flushOutput method. Rather it has to be an independent act.
> When connection opening is within the flushOutput, it becomes harder to debug. Hence it is ideal to move this to out of flushOutput.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (AXISCPP-659) Move connection opening out of flushOutput method
Posted by "Samisa Abeysinghe (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-659?page=all ]
Samisa Abeysinghe closed AXISCPP-659:
-------------------------------------
Resolution: Fixed
The tests with this change are successful.
There were no side effects
> Move connection opening out of flushOutput method
> -------------------------------------------------
>
> Key: AXISCPP-659
> URL: http://issues.apache.org/jira/browse/AXISCPP-659
> Project: Axis-C++
> Type: Improvement
> Components: Transport (axis3)
> Versions: 1.5 Final
> Reporter: Samisa Abeysinghe
> Assignee: Samisa Abeysinghe
> Fix For: 1.6 Alpha
>
> Connection opening should not be the responsibility of the flushOutput method. Rather it has to be an independent act.
> When connection opening is within the flushOutput, it becomes harder to debug. Hence it is ideal to move this to out of flushOutput.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira