You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2013/10/25 03:15:15 UTC
Review Request 14919: HIVE-5351: Secure-Socket-Layer (SSL) support for
HiveServer2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14919/
-----------------------------------------------------------
Review request for hive and Brock Noland.
Bugs: HIVE-5351
https://issues.apache.org/jira/browse/HIVE-5351
Repository: hive-git
Description
-------
Add support for encrypted communication for Plain SASL for binary thrift transport.
- Optional thrift SSL transport on server side if configured.
- Optional thrift SSL transport for JDBC client with configurable trust store
Diffs
-----
build.properties 3009bba
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java abfde42
data/files/keystore.jks PRE-CREATION
data/files/truststore.jks PRE-CREATION
eclipse-templates/TestJdbcMiniHS2.launchtemplate PRE-CREATION
jdbc/build.xml d3c0f0c
jdbc/ivy.xml b9d0cea
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java f155686
jdbc/src/test/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java PRE-CREATION
jdbc/src/test/org/apache/hive/jdbc/TestSSL.java PRE-CREATION
jdbc/src/test/org/apache/hive/jdbc/miniHS2/AbstarctHiveService.java PRE-CREATION
jdbc/src/test/org/apache/hive/jdbc/miniHS2/MiniHS2.java PRE-CREATION
jdbc/src/test/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 24b1832
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 5a66a6c
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 9c8f5c1
shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 623ebcd
Diff: https://reviews.apache.org/r/14919/diff/
Testing
-------
- Added a miniHS2 class that to manage thrift hiveserver2 for testing
- Basic HiveServer2 test cases with miniHS2
- Added multiple test cases for SSL transport
Thanks,
Prasad Mujumdar
Re: Review Request 14919: HIVE-5351: Secure-Socket-Layer (SSL) support for
HiveServer2
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14919/#review28325
-----------------------------------------------------------
Ship it!
+1 pending tests
- Brock Noland
On Nov. 6, 2013, 9:03 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14919/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 9:03 p.m.)
>
>
> Review request for hive and Brock Noland.
>
>
> Bugs: HIVE-5351
> https://issues.apache.org/jira/browse/HIVE-5351
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Add support for encrypted communication for Plain SASL for binary thrift transport.
> - Optional thrift SSL transport on server side if configured.
> - Optional thrift SSL transport for JDBC client with configurable trust store
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6dadd9c
> data/files/keystore.jks PRE-CREATION
> data/files/truststore.jks PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstarctHiveService.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java PRE-CREATION
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java PRE-CREATION
> jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 5a6ce44
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 02530b0
> service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 5a66a6c
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 9c8f5c1
> shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 623ebcd
> shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java fd274a6
>
> Diff: https://reviews.apache.org/r/14919/diff/
>
>
> Testing
> -------
>
> - Added a miniHS2 class that to manage thrift hiveserver2 for testing
> - Basic HiveServer2 test cases with miniHS2
> - Added multiple test cases for SSL transport
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 14919: HIVE-5351: Secure-Socket-Layer (SSL) support for
HiveServer2
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14919/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 9:03 p.m.)
Review request for hive and Brock Noland.
Changes
-------
Rebase after maven build framework.
Bugs: HIVE-5351
https://issues.apache.org/jira/browse/HIVE-5351
Repository: hive-git
Description
-------
Add support for encrypted communication for Plain SASL for binary thrift transport.
- Optional thrift SSL transport on server side if configured.
- Optional thrift SSL transport for JDBC client with configurable trust store
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6dadd9c
data/files/keystore.jks PRE-CREATION
data/files/truststore.jks PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstarctHiveService.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java PRE-CREATION
itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java PRE-CREATION
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 5a6ce44
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 02530b0
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 5a66a6c
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 9c8f5c1
shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 623ebcd
shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java fd274a6
Diff: https://reviews.apache.org/r/14919/diff/
Testing
-------
- Added a miniHS2 class that to manage thrift hiveserver2 for testing
- Basic HiveServer2 test cases with miniHS2
- Added multiple test cases for SSL transport
Thanks,
Prasad Mujumdar