You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/28 02:46:32 UTC
[kudu-CR] [thirdparty] bump cmake version up to 3.16.4
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15314
Change subject: [thirdparty] bump cmake version up to 3.16.4
......................................................................
[thirdparty] bump cmake version up to 3.16.4
As it turned out, cmake versions prior to 3.11.2 had issues while
building Kudu with OpenJDK 11. Those issues are fixed as of version
3.11.2. This patch updates cmake up to the latest released version
3.16.4.
NOTE: if both pre-JDK 10 and OpenJDK 11 are installed, the issue
was not manifesting itself; the issue appears only if
OpenJDK 10/11 is the only version installed.
Change-Id: I451445149a21fbe74cda786ab289a03ff21aeb5e
---
M CMakeLists.txt
M thirdparty/vars.sh
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/15314/1
--
To view, visit http://gerrit.cloudera.org:8080/15314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I451445149a21fbe74cda786ab289a03ff21aeb5e
Gerrit-Change-Number: 15314
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] bump cmake version up to 3.16.4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15314 )
Change subject: [thirdparty] bump cmake version up to 3.16.4
......................................................................
Patch Set 1:
> > Build Failed
> >
> > http://jenkins.kudu.apache.org/job/kudu-gerrit/20572/ : FAILURE
>
> Interesting, it worked for me for building at CentOS8.1
It also builds find on macOS, but certainly there is much more stuff built and tested with 3.16.4 version than in 3.9.0. Most likely, we need only a small portion of that and certainly we need to set -std=c++98 or alike.
--
To view, visit http://gerrit.cloudera.org:8080/15314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I451445149a21fbe74cda786ab289a03ff21aeb5e
Gerrit-Change-Number: 15314
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 28 Feb 2020 03:40:54 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] bump cmake version up to 3.16.4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15314 )
Change subject: [thirdparty] bump cmake version up to 3.16.4
......................................................................
Patch Set 1:
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/20572/ : FAILURE
Interesting, it worked for me for building at CentOS8.1
--
To view, visit http://gerrit.cloudera.org:8080/15314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I451445149a21fbe74cda786ab289a03ff21aeb5e
Gerrit-Change-Number: 15314
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 28 Feb 2020 03:19:34 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] bump cmake version up to 3.16.4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/15314 )
Change subject: [thirdparty] bump cmake version up to 3.16.4
......................................................................
Abandoned
Obsoleted by https://gerrit.cloudera.org/#/c/15317/
I'm not sure I want to spend my time on debugging build failures on CentOS6 with devtoolset-3
--
To view, visit http://gerrit.cloudera.org:8080/15314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I451445149a21fbe74cda786ab289a03ff21aeb5e
Gerrit-Change-Number: 15314
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>