You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Surya Hebbar (Code Review)" <ge...@cloudera.org> on 2024/06/28 15:02:06 UTC
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Surya Hebbar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21558
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
IMPALA-13189: Reset the database on clearing imported query profiles
On clicking the "X" button beside the imported query profiles
section header, deleting the entire "imported_profiles" database
and recreating it instead of clearing the "profiles" object store
would be more beneficial.
This could potentially resolve problems with indexing in the database.
When the "imported_profiles" database is being deleted, a message is
displayed adjacent to the imported query profiles section header
to ensure page is not reloaded / closed during the process.
Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
---
M www/queries.tmpl
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/21558/1
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 16:05:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 1: Code-Review+2
Changing my vote to +2 since there is no other comments.
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 16:04:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16444/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 15:28:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
IMPALA-13189: Reset the database on clearing imported query profiles
On clicking the "X" button beside the imported query profiles
section header, deleting the entire "imported_profiles" database
and recreating it instead of clearing the "profiles" object store
would be more beneficial.
This could potentially resolve problems with indexing in the database.
When the "imported_profiles" database is being deleted, a message is
displayed adjacent to the imported query profiles section header
to ensure page is not reloaded / closed during the process.
Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Reviewed-on: http://gerrit.cloudera.org:8080/21558
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M www/queries.tmpl
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 3
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 18:02:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 1:
Please let me know if any other changes are required.
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 1
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 06:54:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10827/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 16:05:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13189: Reset the database on clearing imported query profiles
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21558 )
Change subject: IMPALA-13189: Reset the database on clearing imported query profiles
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c70b4aaf66f6dc3804a279928d610475834e4f3
Gerrit-Change-Number: 21558
Gerrit-PatchSet: 2
Gerrit-Owner: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 21:22:24 +0000
Gerrit-HasComments: No