You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Paul Ferraro <pm...@columbia.edu> on 2004/02/03 04:04:14 UTC

[PATCH] Javadoc update for org.apache.tapestry.valid.PatternDelegate

While creating a JDK 1.4 regex PatternDelegate implementation for use 
with the PatternValidator, I discovered that the javadoc of the 
org.apache.tapestry.valid.PatternDelegate.contains() method contradicts 
the implementation found in 
org.apache.tapestry.valid.PatternValidator.RegExpDelegate.
Attached is a patch to correct this.

Paul Ferraro


Re: [PATCH] Javadoc update for org.apache.tapestry.valid.PatternDelegate

Posted by Harish Krishnaswamy <hk...@comcast.net>.
Patch applied, thanks.

-Harish

Paul Ferraro wrote:

> While creating a JDK 1.4 regex PatternDelegate implementation for use 
> with the PatternValidator, I discovered that the javadoc of the 
> org.apache.tapestry.valid.PatternDelegate.contains() method 
> contradicts the implementation found in 
> org.apache.tapestry.valid.PatternValidator.RegExpDelegate.
> Attached is a patch to correct this.
>
> Paul Ferraro
>
>------------------------------------------------------------------------
>
>Index: PatternDelegate.java
>===================================================================
>retrieving revision 1.2
>diff -u -r1.2 PatternDelegate.java
>--- PatternDelegate.java	19 Jan 2004 21:32:25 -0000	1.2
>+++ PatternDelegate.java	3 Feb 2004 02:41:33 -0000
>@@ -67,11 +67,11 @@
>     /**
>      * Answers the question whether the input string fulfills the pattern string provided.
>      * 
>-     * @param input The string under test.
>      * @param patternString The pattern that the input string is compared against.
>+     * @param input The string under test.
>      * @return Returns true if the pattern exists in the input string; returns false otherwise.
>      */
>-    public boolean contains(String input, String patternString);
>+    public boolean contains(String patternString, String input);
>     
>     /**
>      * Returns the escaped sequence of characters representing the pattern string provided.
>
>  
>
>------------------------------------------------------------------------
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org