[jira] [Updated] (OAK-6138) Remove addObserver method from Scheduler API

["Andrei Dulceanu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Dulceanu updated OAK-6138:
---------------------------------
    Attachment: OAK-6138-02.patch

[~mduerig], I followed your suggestion regarding having an {{ObsevableLockBasedScheduler}} which gets instantiated in the builder based on {{dispatchChanges}} flag. 

Could you take a look at the latest patch, please?

> Remove addObserver method from Scheduler API
> --------------------------------------------
>
>                 Key: OAK-6138
>                 URL: https://issues.apache.org/jira/browse/OAK-6138
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>             Fix For: 1.8, 1.7.3
>
>         Attachments: OAK-6138-02.patch, OAK-6138.patch
>
>
> We should remove the {{addObserver()}} method from the {{Scheduler}} interface and instead have {{LockBasedScheduler}} implement {{Observable}}(or not depending on the {{dispatchChanges}} flag in {{LockBasedSchedulerBuilder.build()}}. {{SegmentNodeStore.addObserver()}} would then instance of check the scheduler for {{Observable}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)