You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ptupitsyn (via GitHub)" <gi...@apache.org> on 2023/11/08 12:04:12 UTC
[PR] IGNITE-20524 Fix nullable annotations and javadoc in KeyValueView [ignite-3]
ptupitsyn opened a new pull request, #2818:
URL: https://github.com/apache/ignite-3/pull/2818
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20524 Fix nullable annotations and javadoc in KeyValueView [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #2818:
URL: https://github.com/apache/ignite-3/pull/2818#discussion_r1387511093
##########
modules/api/src/main/java/org/apache/ignite/table/KeyValueView.java:
##########
@@ -155,21 +155,21 @@ public interface KeyValueView<K, V> extends DataStreamerTarget<Entry<K, V>> {
*
* @param tx Transaction or {@code null} to auto-commit.
* @param key Key with which the specified value is to be associated. The key cannot be {@code null}.
- * @param val Value to be associated with the specified key.
+ * @param val Value to be associated with the specified key. Can be null when mapped to a single column with a simple type.
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20524 Fix nullable annotations and javadoc in KeyValueView [ignite-3]
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2818:
URL: https://github.com/apache/ignite-3/pull/2818#discussion_r1386974988
##########
modules/api/src/main/java/org/apache/ignite/table/KeyValueView.java:
##########
@@ -155,21 +155,21 @@ public interface KeyValueView<K, V> extends DataStreamerTarget<Entry<K, V>> {
*
* @param tx Transaction or {@code null} to auto-commit.
* @param key Key with which the specified value is to be associated. The key cannot be {@code null}.
- * @param val Value to be associated with the specified key.
+ * @param val Value to be associated with the specified key. Can be null when mapped to a single column with a simple type.
Review Comment:
Here and below
```suggestion
* @param val Value to be associated with the specified key. Can be {@code null} when mapped to a single column with a simple type.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-20524 Fix nullable annotations and javadoc in KeyValueView [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #2818:
URL: https://github.com/apache/ignite-3/pull/2818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org