You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/17 07:45:32 UTC
[GitHub] [incubator-nuttx-testing] GUIDINGLI opened a new pull request #63: cibuild.sh: add objcopy support to MacOS
GUIDINGLI opened a new pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #63: cibuild.sh: add objcopy support to MacOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] yamt commented on pull request #63: cibuild.sh: add objcopy support to MacOS
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63#issuecomment-694072061
i suppose this is for https://github.com/apache/incubator-nuttx/pull/1817, which seems broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] GUIDINGLI commented on a change in pull request #63: cibuild.sh: add objcopy support to MacOS
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on a change in pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63#discussion_r490073325
##########
File path: cibuild.sh
##########
@@ -325,6 +325,18 @@ function c-cache {
ln -sf `which ccache` $prebuilt/ccache/bin/avr-g++
}
+function objcopy {
+
+ if ! type objcopy > /dev/null; then
+ case $os in
+ Darwin)
+ brew install binutils
+ add_path /usr/local/binutils/bin/
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #63: cibuild.sh: add objcopy support to MacOS
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63#discussion_r490048354
##########
File path: cibuild.sh
##########
@@ -325,6 +325,18 @@ function c-cache {
ln -sf `which ccache` $prebuilt/ccache/bin/avr-g++
}
+function objcopy {
+
+ if ! type objcopy > /dev/null; then
+ case $os in
+ Darwin)
+ brew install binutils
+ add_path /usr/local/binutils/bin/
Review comment:
For Darwin should we do the add_path prior to checking if we need to install?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #63: cibuild.sh: add objcopy support to MacOS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63#discussion_r490137617
##########
File path: cibuild.sh
##########
@@ -37,7 +37,7 @@ EXTRA_PATH=
case $os in
Darwin)
- install="python-tools u-boot-tools discoteq-flock elf-toolchain gen-romfs kconfig-frontends arm-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain avr-gcc-toolchain c-cache"
+ install="python-tools u-boot-tools discoteq-flock elf-toolchain gen-romfs kconfig-frontends arm-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain avr-gcc-toolchain c-cache objcopy"
Review comment:
should we change to binutils?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-testing] GUIDINGLI commented on a change in pull request #63: cibuild.sh: add objcopy support to MacOS
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on a change in pull request #63:
URL: https://github.com/apache/incubator-nuttx-testing/pull/63#discussion_r490167405
##########
File path: cibuild.sh
##########
@@ -37,7 +37,7 @@ EXTRA_PATH=
case $os in
Darwin)
- install="python-tools u-boot-tools discoteq-flock elf-toolchain gen-romfs kconfig-frontends arm-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain avr-gcc-toolchain c-cache"
+ install="python-tools u-boot-tools discoteq-flock elf-toolchain gen-romfs kconfig-frontends arm-gcc-toolchain riscv-gcc-toolchain xtensa-esp32-gcc-toolchain avr-gcc-toolchain c-cache objcopy"
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org