You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/09/26 04:00:36 UTC
[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3503: fix close ledgerAuditorManager repeatedly
wenbingshen opened a new pull request, #3503:
URL: https://github.com/apache/bookkeeper/pull/3503
### Motivation
this introduced in #2842, the `ledgerAuditorManager` will be close repeatedly.
```java
private void submitShutdownTask() {
executor.submit(new Runnable() {
@Override
public void run() {
if (!running.compareAndSet(true, false)) {
return;
}
try {
ledgerAuditorManager.close(); <- here has already closed LAM.
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
LOG.warn("InterruptedException while closing ledger auditor manager", ie);
} catch (Exception ke) {
LOG.error("Exception while closing ledger auditor manager", ke);
}
}
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1280245668
@StevenLuMT @zymap Can this PR be merged? Any more questions, please let me know. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1283391387
@zymap Can this pr be merged now. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1257562181
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1257442564
ping @hangc0276 PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1257507198
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap merged pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
zymap merged PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] wenbingshen commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1258397584
also ping @dlg99 @eolivelli @Shoothzj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3503: fix close ledgerAuditorManager repeatedly
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3503:
URL: https://github.com/apache/bookkeeper/pull/3503#issuecomment-1270216471
@eolivelli @dlg99
If you have time,help review this pr,thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org