You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aromanenko-dev (via GitHub)" <gi...@apache.org> on 2023/09/26 11:58:40 UTC

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #27851: Remove Avro-related code from Java SDK "core" module

aromanenko-dev commented on code in PR #27851:
URL: https://github.com/apache/beam/pull/27851#discussion_r1337096172


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/CountingSource.java:
##########
@@ -485,8 +486,8 @@ public long getSplitBacklogBytes() {
    * The checkpoint for an unbounded {@link CountingSource} is simply the last value produced. The
    * associated source object encapsulates the information needed to produce the next value.
    */
-  @DefaultCoder(AvroCoder.class)
-  public static class CounterMark implements UnboundedSource.CheckpointMark {
+  @DefaultCoder(SerializableCoder.class)

Review Comment:
   Right but I don't think Beam supports a hot upgrade. 
   I don't see a way how to avoid such change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org