You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2011/05/19 03:42:54 UTC

svn commit: r1124500 - /myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java

Author: lu4242
Date: Thu May 19 01:42:54 2011
New Revision: 1124500

URL: http://svn.apache.org/viewvc?rev=1124500&view=rev
Log:
MYFACES-3130 [PERF] Avoid unnecessary AbstractList$Itr instances

Modified:
    myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java

Modified: myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java?rev=1124500&r1=1124499&r2=1124500&view=diff
==============================================================================
--- myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java (original)
+++ myfaces/shared/trunk_4.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java Thu May 19 01:42:54 2011
@@ -512,11 +512,12 @@ public final class RendererUtils
     public static void renderChildren(FacesContext facesContext, UIComponent component)
             throws IOException
     {
-        if (component.getChildCount() > 0)
+        int childCount = component.getChildCount();
+        if (childCount > 0)
         {
-            for (Iterator it = component.getChildren().iterator(); it.hasNext(); )
+            for (int i = 0; i < childCount; i++)
             {
-                UIComponent child = (UIComponent)it.next();
+                UIComponent child = component.getChildren().get(i);
                 renderChild(facesContext, child);
             }
         }
@@ -526,10 +527,6 @@ public final class RendererUtils
     public static void renderChild(FacesContext facesContext, UIComponent child)
             throws IOException
     {
-        if (!child.isRendered())
-        {
-            return;
-        }
 
         child.encodeBegin(facesContext);
         if (child.getRendersChildren())