You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/08/01 23:02:51 UTC

[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #245: omega-edit updates

Shanedell commented on code in PR #245:
URL: https://github.com/apache/daffodil-vscode/pull/245#discussion_r934981040


##########
src/omega_edit/omega_edit.ts:
##########
@@ -127,11 +84,101 @@ export class OmegaEdit {
     }
   }
 
+  async prepareSearch(fileSize: number): Promise<string> {
+    let segmentData = await omegaEditSession.getSegment(

Review Comment:
   yes this is the only reason the data is being retrieved. Once search works on the backend it won't grab all the data anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org