You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/22 09:45:21 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
MartijnVisser opened a new pull request, #21550:
URL: https://github.com/apache/flink/pull/21550
What is the purpose of the change
The RabbitMQ connector has been externalized to https://github.com/apache/flink-connector-rabbitmq/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21550:
URL: https://github.com/apache/flink/pull/21550#discussion_r1055399846
##########
.idea/vcs.xml:
##########
@@ -1,5 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
+ <component name="CommitMessageInspectionProfile">
+ <profile version="1.0">
+ <inspection_tool class="CommitFormat" enabled="true" level="WARNING" enabled_by_default="true" />
+ <inspection_tool class="CommitNamingConvention" enabled="true" level="WARNING" enabled_by_default="true" />
+ </profile>
+ </component>
Review Comment:
Mehhh yes, the new IntelliJ keeps changed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #21550:
URL: https://github.com/apache/flink/pull/21550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21550:
URL: https://github.com/apache/flink/pull/21550#issuecomment-1377184761
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21550:
URL: https://github.com/apache/flink/pull/21550#issuecomment-1362633469
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f4376ea1e1bf627d817a8ecf1d90853c53350a18",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4376ea1e1bf627d817a8ecf1d90853c53350a18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4376ea1e1bf627d817a8ecf1d90853c53350a18 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #21550:
URL: https://github.com/apache/flink/pull/21550#discussion_r1056286591
##########
flink-python/pom.xml:
##########
@@ -298,7 +298,7 @@ under the License.
<!-- Indirectly accessed in pyflink_gateway_server -->
<groupId>org.apache.flink</groupId>
<artifactId>flink-sql-connector-rabbitmq</artifactId>
- <version>${project.version}</version>
+ <version>3.0.0-1.16</version>
Review Comment:
That's related to [my comment in the jdbc removal PR](https://github.com/apache/flink/pull/21536#discussion_r1056276909)
##########
docs/data/sql_connectors.yml:
##########
@@ -196,4 +196,4 @@ rabbitmq:
name: RabbitMQ
category: connector
maven: flink-connector-rabbitmq
- sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-rabbitmq/$version/flink-sql-connector-rabbitmq-$version.jar
+ sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-rabbitmq/3.0.0-1.16/flink-sql-connector-rabbitmq-3.0.0-1.16.jar
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #21550: [FLINK-30485][Connector/RabbitMQ] Remove RabbitMQ connector
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #21550:
URL: https://github.com/apache/flink/pull/21550#discussion_r1055363489
##########
.idea/vcs.xml:
##########
@@ -1,5 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
+ <component name="CommitMessageInspectionProfile">
+ <profile version="1.0">
+ <inspection_tool class="CommitFormat" enabled="true" level="WARNING" enabled_by_default="true" />
+ <inspection_tool class="CommitNamingConvention" enabled="true" level="WARNING" enabled_by_default="true" />
+ </profile>
+ </component>
Review Comment:
Added accidentally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org