[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7334: Minor: Move shared testing code into datafusion_common

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7334:
URL: https://github.com/apache/arrow-datafusion/pull/7334#discussion_r1298714626


##########
datafusion/common/src/test_util.rs:
##########
@@ -62,3 +64,152 @@ macro_rules! assert_not_contains {
         );
     };
 }
+
+/// Returns the arrow test data directory, which is by default stored

Review Comment:
   this is moved  code -- no changes



##########
datafusion/core/src/datasource/physical_plan/csv.rs:
##########
@@ -1249,4 +1249,20 @@ mod tests {
             }
         }
     }
+
+    /// Get the schema for the aggregate_test_* csv files with an additional filed not present in the files.
+    fn aggr_test_schema_with_missing_col() -> SchemaRef {

Review Comment:
   I moved this out as this is the only place it is used and rewrote it to append the column explicitly rather than copy/paste with one line difference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org