[GitHub] [nifi] NissimShiman commented on pull request #6061: NIFI-5378 prevent duplicate keys with different values in nifi.p…

[GitBox <gi...@apache.org>]

NissimShiman commented on PR #6061:
URL: https://github.com/apache/nifi/pull/6061#issuecomment-1134902560

   Tested with duplicate nifi.web.https.host properties and failed on startup within a 1/10 of a second with clear log about which duplicate key was found.  
   
   For FWIW I like this idea as I've had situations where I had unintended duplicates in nifi.properties and didn't notice until later, but I hear the concerns and wouldn't want current users to have unintended consequences.
   
   Maybe another property can be added,
   nifi.startup.properties.verify.unique
   which by default will be false, but can be set to true
   This property won't even be in the nifi.properties by default, just in the documentation
   for those interested in it.
   
   Log with message details is in nifi-app as opposed to nifi-bootstrap so maybe this could be in nifi-bootstrap as well although it seems most startup issues tend to have the details logged in nifi-app only, so this follows that pattern, so I believe this is fine as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org