You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/16 06:33:58 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #14077: Pr14061 add doc zh
gaoyunhaii opened a new pull request #14077:
URL: https://github.com/apache/flink/pull/14077
## What is the purpose of the change
Translating the `FileSink` document into Chinese.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #14077:
URL: https://github.com/apache/flink/pull/14077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 605e600a9ed9a0fec3cdd872dfa6208626f0a087 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524243329
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -329,18 +329,13 @@ stream.sinkTo(FileSink.forBulkFormat(
#### ORC Format
-To enable the data to be bulk encoded in ORC format, Flink offers [OrcBulkWriterFactory]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/formats/orc/writers/OrcBulkWriterFactory.html)
-which takes a concrete implementation of [Vectorizer]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/orc/vector/Vectorizer.html).
+为了使用基于批量编码的 ORC 格式，Flink提供了 [OrcBulkWriterFactory]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/formats/orc/writers/OrcBulkWriterFactory.html) ，它需要用户提供一个 [Vectorizer]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/orc/vector/Vectorizer.html) 的具体实现。
-Like any other columnar format that encodes data in bulk fashion, Flink's `OrcBulkWriter` writes the input elements in batches. It uses
-ORC's `VectorizedRowBatch` to achieve this.
+和其它基于列式存储的批量编码格式类似，Flink中的 `OrcBulkWriter` 将数据按批写出，它通过 ORC 的 VectorizedRowBatch 来实现这一点。
-Since the input element has to be transformed to a `VectorizedRowBatch`, users have to extend the abstract `Vectorizer`
-class and override the `vectorize(T element, VectorizedRowBatch batch)` method. As you can see, the method provides an
-instance of `VectorizedRowBatch` to be used directly by the users so users just have to write the logic to transform the
-input `element` to `ColumnVectors` and set them in the provided `VectorizedRowBatch` instance.
+由于输入数据必须先缓存为一个完整的 `VectorizedRowBatch` ，用户需要继承 `Vectorizer` 抽像类并且覆盖其中的 `vectorize(T element, VectorizedRowBatch batch)` 方法。方法参数中传入的 `VectorizedRowBatch` 使用户只需将输入 `element` 转化为 `ColumnVectors` 并将它存储到所提供的 `VectorizedRowBatch` 实例中。
Review comment:
覆盖---》实现
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524193952
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -26,35 +26,35 @@ under the License.
* This will be replaced by the TOC
{:toc}
-这个连接器提供了一个 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中。
+这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。
-Streaming File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
+File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
-桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。
+桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。对于批量编码格式我们需要在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的条件。
Review comment:
Maybe we could change the "我们" to more specific. For example ”批量编码格式的默认策略是每次在checkpoint时滚动文件。“
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
}, {
"hash" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681",
"triggerID" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"triggerType" : "PUSH"
}, {
"hash" : "07560726c066d46c95ac580ce597ecc0d827e1ba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9730",
"triggerID" : "07560726c066d46c95ac580ce597ecc0d827e1ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
* 58a2d8188e8ff838e0126cd2241cb89f27a4c9d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681)
* 07560726c066d46c95ac580ce597ecc0d827e1ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9730)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524234047
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -454,8 +449,7 @@ input.sinkTo(sink)
</div>
</div>
-OrcBulkWriterFactory can also take Hadoop `Configuration` and `Properties` so that a custom Hadoop configuration and ORC
-writer properties can be provided.
+用户还可以通过 Hadoop `Configuration` 和 `Properties` 来设置 OrcBulkWriterFactory 中涉及的 Hadoop 属性和 Writer 属性：
Review comment:
Writer ---》 ORC Writer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524234564
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -404,7 +399,7 @@ class PersonVectorizer(schema: String) extends Vectorizer[Person](schema) {
</div>
</div>
-To use the ORC bulk encoder in an application, users need to add the following dependency:
+为了在应用使用 ORC 批量编码，用户需要添加如下依赖：
Review comment:
为了在应用**中**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-728065914
Very thanks @guoweiM for the reviewing and I will update the PR~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-732033153
Very thanks @guoweiM !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524871222
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -479,18 +473,17 @@ val conf: Configuration = ...
val writerProperties: Properties = new Properties()
writerProps.setProperty("orc.compress", "LZ4")
-// Other ORC supported properties can also be set similarly.
+// 其它 ORC 支持的属性也可以类似设置。
val writerFactory = new OrcBulkWriterFactory(
new PersonVectorizer(schema), writerProperties, conf)
{% endhighlight %}
</div>
</div>
-The complete list of ORC writer properties can be found [here](https://orc.apache.org/docs/hive-config.html).
+完整的 ORC Writer 的属性可以参考 [相关文档](https://orc.apache.org/docs/hive-config.html).
-Users who want to add user metadata to the ORC files can do so by calling `addUserMetadata(...)` inside the overriding
-`vectorize(...)` method.
+给 ORC 文件添加自定义元数据可以通过在覆盖的 `vectorize(...)` 方法中调用 `addUserMetadata(...)` 实现：
Review comment:
和下面一样改成 实现 了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
}, {
"hash" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 605e600a9ed9a0fec3cdd872dfa6208626f0a087 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606)
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
* 58a2d8188e8ff838e0126cd2241cb89f27a4c9d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
}, {
"hash" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681",
"triggerID" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
* 58a2d8188e8ff838e0126cd2241cb89f27a4c9d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524870494
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -26,35 +26,35 @@ under the License.
* This will be replaced by the TOC
{:toc}
-这个连接器提供了一个 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中。
+这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。
-Streaming File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
+File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
-桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。
+桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。对于批量编码格式我们需要在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的条件。
Review comment:
A little difference is that the english specify that "must roll on checkpoint", thus translated to "必须切割文件", the other part is changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524870832
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -479,18 +473,17 @@ val conf: Configuration = ...
val writerProperties: Properties = new Properties()
writerProps.setProperty("orc.compress", "LZ4")
-// Other ORC supported properties can also be set similarly.
+// 其它 ORC 支持的属性也可以类似设置。
val writerFactory = new OrcBulkWriterFactory(
new PersonVectorizer(schema), writerProperties, conf)
{% endhighlight %}
</div>
</div>
-The complete list of ORC writer properties can be found [here](https://orc.apache.org/docs/hive-config.html).
+完整的 ORC Writer 的属性可以参考 [相关文档](https://orc.apache.org/docs/hive-config.html).
-Users who want to add user metadata to the ORC files can do so by calling `addUserMetadata(...)` inside the overriding
-`vectorize(...)` method.
+给 ORC 文件添加自定义元数据可以通过在覆盖的 `vectorize(...)` 方法中调用 `addUserMetadata(...)` 实现：
Review comment:
这里应该是 覆盖 不是 重载 哈？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-728204347
@gaoyunhaii I merged the english version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
}, {
"hash" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681",
"triggerID" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"triggerType" : "PUSH"
}, {
"hash" : "07560726c066d46c95ac580ce597ecc0d827e1ba",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9730",
"triggerID" : "07560726c066d46c95ac580ce597ecc0d827e1ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
* 07560726c066d46c95ac580ce597ecc0d827e1ba Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9730)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-728065488
> Hi @gaoyunhaii , just to avoid doing redundant work, it may make sense to wait for the english docs to get finalised before merging this one. I hope this will be done soon #14061.
+1 for wait till the english doc get merged and then I would also modify the translation to reveal the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524240352
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -329,18 +329,13 @@ stream.sinkTo(FileSink.forBulkFormat(
#### ORC Format
-To enable the data to be bulk encoded in ORC format, Flink offers [OrcBulkWriterFactory]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/formats/orc/writers/OrcBulkWriterFactory.html)
-which takes a concrete implementation of [Vectorizer]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/orc/vector/Vectorizer.html).
+为了使用基于批量编码的 ORC 格式，Flink提供了 [OrcBulkWriterFactory]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/formats/orc/writers/OrcBulkWriterFactory.html) ，它需要用户提供一个 [Vectorizer]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/orc/vector/Vectorizer.html) 的具体实现。
Review comment:
,---》。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727769142
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 605e600a9ed9a0fec3cdd872dfa6208626f0a087 (Mon Nov 16 06:36:55 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524240775
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -329,18 +329,13 @@ stream.sinkTo(FileSink.forBulkFormat(
#### ORC Format
-To enable the data to be bulk encoded in ORC format, Flink offers [OrcBulkWriterFactory]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/formats/orc/writers/OrcBulkWriterFactory.html)
-which takes a concrete implementation of [Vectorizer]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/orc/vector/Vectorizer.html).
+为了使用基于批量编码的 ORC 格式，Flink提供了 [OrcBulkWriterFactory]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/formats/orc/writers/OrcBulkWriterFactory.html) ，它需要用户提供一个 [Vectorizer]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/orc/vector/Vectorizer.html) 的具体实现。
-Like any other columnar format that encodes data in bulk fashion, Flink's `OrcBulkWriter` writes the input elements in batches. It uses
-ORC's `VectorizedRowBatch` to achieve this.
+和其它基于列式存储的批量编码格式类似，Flink中的 `OrcBulkWriter` 将数据按批写出，它通过 ORC 的 VectorizedRowBatch 来实现这一点。
Review comment:
,---->。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
}, {
"hash" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681",
"triggerID" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 605e600a9ed9a0fec3cdd872dfa6208626f0a087 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606)
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
* 58a2d8188e8ff838e0126cd2241cb89f27a4c9d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524196345
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -26,35 +26,35 @@ under the License.
* This will be replaced by the TOC
{:toc}
-这个连接器提供了一个 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中。
+这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。
-Streaming File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
+File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
-桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。
+桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。对于批量编码格式我们需要在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的条件。
Review comment:
>>>”时间的条件“
Maybe we could change the "条件" to "策略" for keeping the consistence.
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -26,35 +26,35 @@ under the License.
* This will be replaced by the TOC
{:toc}
-这个连接器提供了一个 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中。
+这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。
-Streaming File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
+File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
-桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。
+桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。对于批量编码格式我们需要在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的条件。
Review comment:
>>>”时间的条件“
Maybe we could change the "条件" to "策略" for keeping the consistence.
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -26,35 +26,35 @@ under the License.
* This will be replaced by the TOC
{:toc}
-这个连接器提供了一个 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中。
+这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。
-Streaming File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
+File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
-桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。
+桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。对于批量编码格式我们需要在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的条件。
Review comment:
>”时间的条件“
Maybe we could change the "条件" to "策略" for keeping the consistence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 605e600a9ed9a0fec3cdd872dfa6208626f0a087 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524998101
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -26,11 +26,11 @@ under the License.
* This will be replaced by the TOC
{:toc}
-这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。
+这个连接器提供了一个在流和批模式下统一的 Sink 来将分区文件写入到支持 [Flink `FileSystem`]({{ site.baseurl}}/zh/ops/filesystems/index.html) 接口的文件系统中，它对于流和批模式可以提供相同的一致性语义保证。File Sink 是现有的 [Streaming File Sink]({{ site.baseurl }}/zh/dev/connectors/streamfile_sink.html) 的一个升级版本，后者仅在流模式下提供了精确一致性。
File Sink 会将数据写入到桶中。由于输入流可能是无界的，因此每个桶中的数据被划分为多个有限大小的文件。如何分桶是可以配置的，默认使用基于时间的分桶策略，这种策略每个小时创建一个新的桶，桶中包含的文件将记录所有该小时内从流中接收到的数据。
-桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。对于批量编码格式我们需要在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的条件。
+桶目录中的实际输出数据会被划分为多个部分文件（part file），每一个接收桶数据的 Sink Subtask ，至少包含一个部分文件（part file）。额外的部分文件（part file）将根据滚动策略创建，滚动策略是可以配置的。对于行编码格式（参考 [File Formats](#file-formats) ）默认的策略是根据文件大小和超时时间来滚动文件。超时时间指打开文件的最长持续时间，以及文件关闭前的最长非活动时间。批量编码格式必须在每次 Checkpoint 时切割文件，但是用户也可以指定额外的基于文件大小和超时时间的策略。
Review comment:
Why we use the "切割文件" not "滚动文件", which is consistent with other part in this section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727945192
Hi @gaoyunhaii , just to avoid doing redundant work, it may make sense to wait for the english docs to get finalised before merging this one. I hope this will be done soon https://github.com/apache/flink/pull/14061.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-728718085
@guoweiM @kl0u Very thanks, I have updated the rebased the PR, and modified it according to the latest English version and comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 605e600a9ed9a0fec3cdd872dfa6208626f0a087 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606)
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524218755
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -603,7 +604,7 @@ Flink 有两个内置的 BucketAssigners ：
## 滚动策略
-滚动策略 [RollingPolicy]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/streaming/api/functions/sink/filesystem/RollingPolicy.html) 定义了指定的文件在何时关闭（closed）并将其变为 Pending 状态，随后变为 Finished 状态。处于 Pending 状态的文件会在下一次 Checkpoint 时变为 Finished 状态，通过设置 Checkpoint 间隔时间，可以控制部分文件（part file）对下游读取者可用的速度、大小和数量。
+在流模式下，滚动策略 [RollingPolicy]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/streaming/api/functions/sink/filesystem/RollingPolicy.html) 定义了指定的文件在何时关闭（closed）并将其变为 Pending 状态，随后变为 Finished 状态。处于 Pending 状态的文件会在下一次 Checkpoint 时变为 Finished 状态，通过设置 Checkpoint 间隔时间，可以控制部分文件（part file）对下游读取者可用的速度、大小和数量。在批模式下，临时文件只会在作业处理完所有输入数据后提交，此时滚动策略可以用来控制每个文件的大小。
Review comment:
Maybe we could not introduce a new concept "临时文件". So maybe we could change to following ：
在批模式下，所有文件只会在作业处理完所有输入数据后变为Finished状态
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20180][fs-connector][translation] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
}, {
"hash" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca8f49ba4692b44a600929f6e0c14b6da6a2ce85",
"triggerType" : "PUSH"
}, {
"hash" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681",
"triggerID" : "58a2d8188e8ff838e0126cd2241cb89f27a4c9d2",
"triggerType" : "PUSH"
}, {
"hash" : "07560726c066d46c95ac580ce597ecc0d827e1ba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07560726c066d46c95ac580ce597ecc0d827e1ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca8f49ba4692b44a600929f6e0c14b6da6a2ce85 UNKNOWN
* 58a2d8188e8ff838e0126cd2241cb89f27a4c9d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9681)
* 07560726c066d46c95ac580ce597ecc0d827e1ba UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524218755
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -603,7 +604,7 @@ Flink 有两个内置的 BucketAssigners ：
## 滚动策略
-滚动策略 [RollingPolicy]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/streaming/api/functions/sink/filesystem/RollingPolicy.html) 定义了指定的文件在何时关闭（closed）并将其变为 Pending 状态，随后变为 Finished 状态。处于 Pending 状态的文件会在下一次 Checkpoint 时变为 Finished 状态，通过设置 Checkpoint 间隔时间，可以控制部分文件（part file）对下游读取者可用的速度、大小和数量。
+在流模式下，滚动策略 [RollingPolicy]({{ site.javadocs_baseurl }}/api/java/org/apache/flink/streaming/api/functions/sink/filesystem/RollingPolicy.html) 定义了指定的文件在何时关闭（closed）并将其变为 Pending 状态，随后变为 Finished 状态。处于 Pending 状态的文件会在下一次 Checkpoint 时变为 Finished 状态，通过设置 Checkpoint 间隔时间，可以控制部分文件（part file）对下游读取者可用的速度、大小和数量。在批模式下，临时文件只会在作业处理完所有输入数据后提交，此时滚动策略可以用来控制每个文件的大小。
Review comment:
Maybe we could not introduce a new concept "临时文件". So maybe we could change to following ：
在批模式下，所有文件只会在作业处理完所有输入数据后才变为Finished状态
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #14077:
URL: https://github.com/apache/flink/pull/14077#discussion_r524233273
##########
File path: docs/dev/connectors/file_sink.zh.md
##########
@@ -479,18 +473,17 @@ val conf: Configuration = ...
val writerProperties: Properties = new Properties()
writerProps.setProperty("orc.compress", "LZ4")
-// Other ORC supported properties can also be set similarly.
+// 其它 ORC 支持的属性也可以类似设置。
val writerFactory = new OrcBulkWriterFactory(
new PersonVectorizer(schema), writerProperties, conf)
{% endhighlight %}
</div>
</div>
-The complete list of ORC writer properties can be found [here](https://orc.apache.org/docs/hive-config.html).
+完整的 ORC Writer 的属性可以参考 [相关文档](https://orc.apache.org/docs/hive-config.html).
-Users who want to add user metadata to the ORC files can do so by calling `addUserMetadata(...)` inside the overriding
-`vectorize(...)` method.
+给 ORC 文件添加自定义元数据可以通过在覆盖的 `vectorize(...)` 方法中调用 `addUserMetadata(...)` 实现：
Review comment:
”覆盖“ -》 重载
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14077: [FLINK-20141][fs-connector] Translate FileSink document into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14077:
URL: https://github.com/apache/flink/pull/14077#issuecomment-727773204
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606",
"triggerID" : "605e600a9ed9a0fec3cdd872dfa6208626f0a087",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 605e600a9ed9a0fec3cdd872dfa6208626f0a087 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org