You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/30 09:02:27 UTC

[GitHub] [pulsar] urfreespace commented on a diff in pull request #16298: When generate doc, ignore the hidden parameters.

urfreespace commented on code in PR #16298:
URL: https://github.com/apache/pulsar/pull/16298#discussion_r910785709


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/BaseGenerateDocumentation.java:
##########
@@ -90,7 +90,7 @@ protected String generateDocByFieldContext(String className, String type, String
         sb.append("|---|---|---|---|---|\n");
         for (Field field : fields) {
             FieldContext fieldContext = field.getAnnotation(FieldContext.class);
-            if (fieldContext == null) {
+            if (fieldContext == null || fieldContext.deprecated()) {

Review Comment:
   @Anonymitaet any idea? I think it's not a tech question



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org