You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/09/02 11:58:26 UTC
[GitHub] [drill] ihuzenko commented on a change in pull request #1829:
DRILL-7096: Develop vector for canonical Map
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r319899067
##########
File path: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/reader/FieldReader.java
##########
@@ -22,7 +22,9 @@
import org.apache.drill.exec.vector.complex.reader.BaseReader.MapReader;
import org.apache.drill.exec.vector.complex.reader.BaseReader.RepeatedListReader;
import org.apache.drill.exec.vector.complex.reader.BaseReader.RepeatedMapReader;
+import org.apache.drill.exec.vector.complex.reader.BaseReader.DictReader;
import org.apache.drill.exec.vector.complex.reader.BaseReader.ScalarReader;
-public interface FieldReader extends MapReader, ListReader, ScalarReader, RepeatedMapReader, RepeatedListReader, UntypedReader {
+public interface FieldReader extends MapReader, DictReader, ListReader, ScalarReader, RepeatedMapReader, RepeatedListReader, UntypedReader {
+ String getTypeString();
Review comment:
please provide javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services