You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/22 02:26:43 UTC

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #758: feat: added Contribute page

juzhiyuan commented on a change in pull request #758:
URL: https://github.com/apache/apisix-website/pull/758#discussion_r753907958



##########
File path: website/config/navbar.js
##########
@@ -106,6 +106,11 @@ module.exports = [
     label: "Showcase",
     position: "right",
   },
+  {
+    to: "/contribute",

Review comment:
       A little strange to use this URL 😅 But I couldn't find a better one.

##########
File path: website/src/assets/icons/comment.svg
##########
@@ -0,0 +1 @@
+<?xml version="1.0" standalone="no"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg class="icon" width="16px" height="16.00px" viewBox="0 0 1024 1024" version="1.1" xmlns="http://www.w3.org/2000/svg"><path fill="#333333" d="M896.4 195.6c-19.1-19.2-44.5-29.8-71.5-29.8l-587.9-0.9h-0.2c-55.7 0-101.1 45.3-101.2 101.1l-1.1 608.6c-0.1 10 5.5 18.8 14.4 23.2 3.6 1.7 7.5 2.6 11.3 2.6 5.6 0 11.2-1.9 15.8-5.5l127-99.2c2.7-2.1 6.1-3.3 9.5-3.3l511 0.8h0.2c55.8 0 101.2-45.3 101.3-101l0.9-425c0.1-27-10.4-52.4-29.5-71.6zM881 692.1c-0.1 31.5-25.8 57.1-57.3 57.1h-0.1l-511-0.8h-0.1c-13.1 0-26.1 4.5-36.5 12.6l-97.5 76.2 1-571.1c0.1-31.6 25.8-57.2 57.3-57.2l588 0.9c15.3 0 29.6 6 40.4 16.8s16.7 25.2 16.7 40.5l-0.9 425z" /></svg>

Review comment:
       ```suggestion
   <?xml version="1.0" standalone="no"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg class="icon" width="16px" height="16.00px" viewBox="0 0 1024 1024" version="1.1" xmlns="http://www.w3.org/2000/svg"><path fill="#333333" d="M896.4 195.6c-19.1-19.2-44.5-29.8-71.5-29.8l-587.9-0.9h-0.2c-55.7 0-101.1 45.3-101.2 101.1l-1.1 608.6c-0.1 10 5.5 18.8 14.4 23.2 3.6 1.7 7.5 2.6 11.3 2.6 5.6 0 11.2-1.9 15.8-5.5l127-99.2c2.7-2.1 6.1-3.3 9.5-3.3l511 0.8h0.2c55.8 0 101.2-45.3 101.3-101l0.9-425c0.1-27-10.4-52.4-29.5-71.6zM881 692.1c-0.1 31.5-25.8 57.1-57.3 57.1h-0.1l-511-0.8h-0.1c-13.1 0-26.1 4.5-36.5 12.6l-97.5 76.2 1-571.1c0.1-31.6 25.8-57.2 57.3-57.2l588 0.9c15.3 0 29.6 6 40.4 16.8s16.7 25.2 16.7 40.5l-0.9 425z" /></svg>
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org