[GitHub] [helix] lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.
URL: https://github.com/apache/helix/pull/337#discussion_r304160164
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
 ##########
 @@ -259,7 +259,7 @@ private boolean computeResourceBestPossibleState(ClusterEvent event, ResourceCon
         return checkBestPossibleStateCalculation(idealState);
       } catch (Exception e) {
         LogUtil
-            .logError(logger, _eventId, "Error computing assignment for resource " + resourceName + ". Skipping.", e);
+            .logError(logger, _eventId, "Error computing assignment for resource " + resourceName + ". Skipping.");
 
 Review comment:
   should we print out the exception message, i.e, e.getMessage()? otherwise, do we know what error it encounters?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services