You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/05/16 14:34:55 UTC
Review Request 59314: Fixed the fd type in tests for consistency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59314/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/containerizer/io_switchboard_tests.cpp b19961ee91af3c174d4377c2514465d6c99cf331
src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8c1511d1a85c0e3bf985404da2abff9039e3e27
Diff: https://reviews.apache.org/r/59314/diff/1/
Testing
-------
`make check` on various Linux distros
Thanks,
Alexander Rukletsov
Re: Review Request 59314: Fixed the fd type in tests for consistency.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59314/#review175346
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59314]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 16, 2017, 2:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59314/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 2:34 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp b19961ee91af3c174d4377c2514465d6c99cf331
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8c1511d1a85c0e3bf985404da2abff9039e3e27
>
>
> Diff: https://reviews.apache.org/r/59314/diff/1/
>
>
> Testing
> -------
>
> `make check` on various Linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59314: Fixed the fd type in tests for consistency.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59314/#review175316
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 16, 2017, 2:34 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59314/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 2:34 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp b19961ee91af3c174d4377c2514465d6c99cf331
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8c1511d1a85c0e3bf985404da2abff9039e3e27
>
>
> Diff: https://reviews.apache.org/r/59314/diff/1/
>
>
> Testing
> -------
>
> `make check` on various Linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>