[GitHub] [tvm] shingjan commented on a diff in pull request #11922: [PyTorch] [Relay] Add aten::pad

[GitBox <gi...@apache.org>]

shingjan commented on code in PR #11922:
URL: https://github.com/apache/tvm/pull/11922#discussion_r907706887


##########
python/tvm/relay/frontend/pytorch.py:
##########
@@ -3142,12 +3178,13 @@ def create_convert_map(self):
             "prim::NumToTensor": self.numtotensor,
             "prim::ImplicitTensorToNum": self.tensortonum,
             "aten::ScalarImplicit": self.tensortonum,
-            "aten::constant_pad_nd": self.make_pad("constant"),
-            "aten::reflection_pad1d": self.make_pad("reflect"),
-            "aten::reflection_pad2d": self.make_pad("reflect"),
-            "aten::replication_pad1d": self.make_pad("edge"),
-            "aten::replication_pad2d": self.make_pad("edge"),
-            "aten::replication_pad3d": self.make_pad("edge"),
+            "aten::pad": self.pad,

Review Comment:
   Seems to me that only with this change `test_forward_functional_pad` was able to work on my local end, is this test disabled before on CI? This is also the reason why I am not adding a new test case. @masahi 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org