You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Kasper Sørensen <i....@gmail.com> on 2015/05/18 21:43:27 UTC
Review Request 34366: METAMODEL-141: ColumnType mapping to common
RDBMSes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34366/
-----------------------------------------------------------
Review request for MetaModel.
Bugs: METAMODEL-141
https://issues.apache.org/jira/browse/METAMODEL-141
Repository: metamodel
Description
-------
Made the column type rewriting also aware of column size.
Added an Oracle dialect.
Made many adjustments to column type mapping based on information (wiki, DB manuals etc.) about which data types are missing/superceeded in various DBs.
Diffs
-----
CHANGES.md cff4ce4
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java c0a5999
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java f83057e
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java 03e9318
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java 1ac72bc
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/HsqldbQueryRewriter.java cc3d202
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/IQueryRewriter.java 17140e3
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/MysqlQueryRewriter.java 3c0037b
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java PRE-CREATION
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/PostgresqlQueryRewriter.java c3fd322
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java d83d6d2
jdbc/src/test/java/org/apache/metamodel/dialects/DB2QueryRewriterTest.java 9108461
jdbc/src/test/java/org/apache/metamodel/dialects/MysqlQueryRewriterTest.java f9aec48
jdbc/src/test/java/org/apache/metamodel/dialects/SQLServerQueryRewriterTest.java fd55486
jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java 9794f4c
Diff: https://reviews.apache.org/r/34366/diff/
Testing
-------
Only unittesting and some sparse manual testing in MySQL and PostgreSQL.
Not yet integration tested on MS SQL and Oracle.
Thanks,
Kasper Sørensen
Re: Review Request 34366: METAMODEL-141: ColumnType mapping to common
RDBMSes
Posted by Kasper Sørensen <i....@gmail.com>.
> On maj 19, 2015, 9:14 a.m., Dennis Krøger wrote:
> > jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java, line 76
> > <https://reviews.apache.org/r/34366/diff/1/?file=963136#file963136line76>
> >
> > Is this a leftover, or was there supposed to be a test here?
Actually wanted to have a test that verifies the proper resolution of the OracleQueryRewriter ... Will add that.
Thanks for the review.
- Kasper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34366/#review84284
-----------------------------------------------------------
On maj 18, 2015, 7:43 p.m., Kasper Sørensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34366/
> -----------------------------------------------------------
>
> (Updated maj 18, 2015, 7:43 p.m.)
>
>
> Review request for MetaModel.
>
>
> Bugs: METAMODEL-141
> https://issues.apache.org/jira/browse/METAMODEL-141
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Made the column type rewriting also aware of column size.
> Added an Oracle dialect.
> Made many adjustments to column type mapping based on information (wiki, DB manuals etc.) about which data types are missing/superceeded in various DBs.
>
>
> Diffs
> -----
>
> CHANGES.md cff4ce4
> jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java c0a5999
> jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java f83057e
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java 03e9318
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java 1ac72bc
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/HsqldbQueryRewriter.java cc3d202
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/IQueryRewriter.java 17140e3
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/MysqlQueryRewriter.java 3c0037b
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java PRE-CREATION
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/PostgresqlQueryRewriter.java c3fd322
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java d83d6d2
> jdbc/src/test/java/org/apache/metamodel/dialects/DB2QueryRewriterTest.java 9108461
> jdbc/src/test/java/org/apache/metamodel/dialects/MysqlQueryRewriterTest.java f9aec48
> jdbc/src/test/java/org/apache/metamodel/dialects/SQLServerQueryRewriterTest.java fd55486
> jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java 9794f4c
>
> Diff: https://reviews.apache.org/r/34366/diff/
>
>
> Testing
> -------
>
> Only unittesting and some sparse manual testing in MySQL and PostgreSQL.
> Not yet integration tested on MS SQL and Oracle.
>
>
> Thanks,
>
> Kasper Sørensen
>
>
Re: Review Request 34366: METAMODEL-141: ColumnType mapping to common
RDBMSes
Posted by Dennis Krøger <De...@humaninference.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34366/#review84284
-----------------------------------------------------------
Ship it!
LGTM, except either a missing test, or an uneeded test method. Nothing important.
jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java
<https://reviews.apache.org/r/34366/#comment135504>
Is this a leftover, or was there supposed to be a test here?
- Dennis Krøger
On May 18, 2015, 7:43 p.m., Kasper Sørensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34366/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 7:43 p.m.)
>
>
> Review request for MetaModel.
>
>
> Bugs: METAMODEL-141
> https://issues.apache.org/jira/browse/METAMODEL-141
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Made the column type rewriting also aware of column size.
> Added an Oracle dialect.
> Made many adjustments to column type mapping based on information (wiki, DB manuals etc.) about which data types are missing/superceeded in various DBs.
>
>
> Diffs
> -----
>
> CHANGES.md cff4ce4
> jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java c0a5999
> jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java f83057e
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java 03e9318
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java 1ac72bc
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/HsqldbQueryRewriter.java cc3d202
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/IQueryRewriter.java 17140e3
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/MysqlQueryRewriter.java 3c0037b
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java PRE-CREATION
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/PostgresqlQueryRewriter.java c3fd322
> jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java d83d6d2
> jdbc/src/test/java/org/apache/metamodel/dialects/DB2QueryRewriterTest.java 9108461
> jdbc/src/test/java/org/apache/metamodel/dialects/MysqlQueryRewriterTest.java f9aec48
> jdbc/src/test/java/org/apache/metamodel/dialects/SQLServerQueryRewriterTest.java fd55486
> jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java 9794f4c
>
> Diff: https://reviews.apache.org/r/34366/diff/
>
>
> Testing
> -------
>
> Only unittesting and some sparse manual testing in MySQL and PostgreSQL.
> Not yet integration tested on MS SQL and Oracle.
>
>
> Thanks,
>
> Kasper Sørensen
>
>