You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2016/07/27 19:47:12 UTC

[GitHub] spark pull request #13824: [SPARK-16110][YARN][PYSPARK] Fix allowing python ...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13824#discussion_r72509645
  
    --- Diff: yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala ---
    @@ -188,7 +202,9 @@ class YarnClusterSuite extends BaseYarnClusterSuite {
         checkResult(finalState, executorResult, "ORIGINAL")
       }
     
    -  private def testPySpark(clientMode: Boolean): Unit = {
    +  private def testPySpark(clientMode: Boolean,
    +                          extraConf: Map[String, String] = Map(),
    --- End diff --
    
    sorry, one last nit. style for multi-line args is:
    
    ```
    def method(
        arg1: Foo,
        arg2: Bar): Unit = {
    
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org