You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lieven Govaerts <lg...@mobsol.be> on 2006/04/03 18:46:28 UTC
[PATCH] issue 2486: Svnserve 1.3 authz: writing on subfolder requires read access on repository root (repost)
Hi,
this patch has been sitting on the mailing list for over a month now. People
have been asking about it alot so I hope somebody finds the time to review
and - if accepted - commit it.
Previous discussion on this patch can be found here:
http://svn.haxx.se/dev/archive-2006-03/0003.shtml
http://svn.haxx.se/dev/archive-2006-01/0704.shtml
In short, the problem is that the commit-editor with the new authz code in
svnserve 1.3 requests read-access on a folder, for just opening it
(open_root, open_directory). The result is that, to use the authz code in
svnserve, you have to give all users readaccess on root!
This patch removes these readaccess checks, as they are not needed for just
traversing a folder.
Python tests are included.
regards,
Lieven.
[[[
Fix for issue #2486: Svnserve 1.3 authz: writing on subfolder requires read
access on repository root
Removed overly restrictive tests for read access when opening root or
opening a directory.
Patch by: Lieven Govaerts <lg...@mobsol.be>
* subversion/libsvn_repos/commit.c:
(open_root): removed check on read access
(open_directory): removed check on read access
* subversion/tests/cmdline/authz_tests.py:
new file, contains tests for issue #2486.
* subversion/tests/cmdline/svntest/actions.py:
(run_and_verify_commit): add --username and --password parameters to the
commit.
* subversion/tests/cmdline/svntest/main.py:
(get_authz_file_path): new function
(get_svnserve_conf_file_path): new function
* subversion/tests/libsvn_repos/repos-test.c:
(commit_editor_authz): removed a now obsolete part of the test.
]]]
Re: [PATCH] issue 2486: Svnserve 1.3 authz: writing on subfolder requires read access on repository root (repost)
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 4/3/06, Lieven Govaerts <lg...@mobsol.be> wrote:
> Updated patch, cleanup the authz_tests.py file.
Committed in r19143 with a few minor tweaks. Thanks!
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: [PATCH] issue 2486: Svnserve 1.3 authz: writing on subfolder requires read access on repository root (repost)
Posted by Lieven Govaerts <lg...@mobsol.be>.
Updated patch, cleanup the authz_tests.py file.
Lieven.
> -----Original Message-----
> From: Lieven Govaerts [mailto:lgo@mobsol.be]
> Sent: maandag 3 april 2006 20:46
> To: dev@subversion.tigris.org
> Subject: [PATCH] issue 2486: Svnserve 1.3 authz: writing on
> subfolder requires read access on repository root (repost)
>
> Hi,
>
>
> this patch has been sitting on the mailing list for over a
> month now. People have been asking about it alot so I hope
> somebody finds the time to review and - if accepted - commit it.
>
> Previous discussion on this patch can be found here:
> http://svn.haxx.se/dev/archive-2006-03/0003.shtml
> http://svn.haxx.se/dev/archive-2006-01/0704.shtml
>
> In short, the problem is that the commit-editor with the new
> authz code in svnserve 1.3 requests read-access on a folder,
> for just opening it (open_root, open_directory). The result
> is that, to use the authz code in svnserve, you have to give
> all users readaccess on root!
>
> This patch removes these readaccess checks, as they are not
> needed for just traversing a folder.
>
> Python tests are included.
>
> regards,
>
> Lieven.
>
[[[
Fix for issue #2486: Svnserve 1.3 authz: writing on subfolder
requires read access on repository root Removed overly
restrictive tests for read access when opening root or
opening a directory.
Patch by: Lieven Govaerts <lg...@mobsol.be>
* subversion/libsvn_repos/commit.c:
(open_root): removed check on read access
(open_directory): removed check on read access
* subversion/tests/cmdline/authz_tests.py:
new file, contains tests for issue #2486.
* subversion/tests/cmdline/svntest/actions.py:
(run_and_verify_commit): add --username and --password
parameters to the commit.
* subversion/tests/cmdline/svntest/main.py:
(get_authz_file_path): new function
(get_svnserve_conf_file_path): new function
* subversion/tests/libsvn_repos/repos-test.c:
(commit_editor_authz): removed a now obsolete part of the test.
]]]