You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "iJanki-gr (via GitHub)" <gi...@apache.org> on 2023/07/27 13:22:33 UTC
[GitHub] [airflow] iJanki-gr opened a new pull request, #32885: KubernetesPodOperator: add termination_message_policy option
iJanki-gr opened a new pull request, #32885:
URL: https://github.com/apache/airflow/pull/32885
Allow setting termination_message_policy in the Pod container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #32885: Add `termination_message_policy` parameter to `KubernetesPodOperator`
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #32885:
URL: https://github.com/apache/airflow/pull/32885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on a diff in pull request #32885: KubernetesPodOperator: add termination_message_policy option
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #32885:
URL: https://github.com/apache/airflow/pull/32885#discussion_r1276297255
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -238,6 +238,7 @@ class KubernetesPodOperator(BaseOperator):
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
Deprecated - use `on_finish_action` instead.
+ :param termination_message_policy: set container termination_message_policy. Defaults to "File"
Review Comment:
nit: `sets container termination message policy. Default value is "File"`
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -238,6 +238,7 @@ class KubernetesPodOperator(BaseOperator):
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
Deprecated - use `on_finish_action` instead.
+ :param termination_message_policy: set container termination_message_policy. Defaults to "File"
Review Comment:
Can you cover this behaviour using a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] iJanki-gr commented on pull request #32885: KubernetesPodOperator: add termination_message_policy option
Posted by "iJanki-gr (via GitHub)" <gi...@apache.org>.
iJanki-gr commented on PR #32885:
URL: https://github.com/apache/airflow/pull/32885#issuecomment-1655652324
Not sure if the failing test is a blip or not. How can I rerun the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] iJanki-gr commented on a diff in pull request #32885: KubernetesPodOperator: add termination_message_policy option
Posted by "iJanki-gr (via GitHub)" <gi...@apache.org>.
iJanki-gr commented on code in PR #32885:
URL: https://github.com/apache/airflow/pull/32885#discussion_r1276327189
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -238,6 +238,7 @@ class KubernetesPodOperator(BaseOperator):
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
Deprecated - use `on_finish_action` instead.
+ :param termination_message_policy: set container termination_message_policy. Defaults to "File"
Review Comment:
I added a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #32885: KubernetesPodOperator: add termination_message_policy option
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #32885:
URL: https://github.com/apache/airflow/pull/32885#discussion_r1277757694
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -238,6 +238,7 @@ class KubernetesPodOperator(BaseOperator):
state, or the execution is interrupted. If True (default), delete the
pod; if False, leave the pod.
Deprecated - use `on_finish_action` instead.
+ :param termination_message_policy: sets container termination message policy. Default value is "File"
Review Comment:
nit
```suggestion
:param termination_message_policy: The termination message policy of the base container.
Default value is "File"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #32885: KubernetesPodOperator: add termination_message_policy option
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #32885:
URL: https://github.com/apache/airflow/pull/32885#issuecomment-1655950358
You can re run by closing and reopening the pull request or by rebasing the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org