You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "toaditi (via GitHub)" <gi...@apache.org> on 2026/07/29 08:40:44 UTC
[PR] Fixed: Time zones always displayed using their daylight savings display name (OFBIZ-12731) [ofbiz-framework]
toaditi opened a new pull request, #1510:
URL: https://github.com/apache/ofbiz-framework/pull/1510
[OFBIZ-12731](https://issues.apache.org/jira/browse/OFBIZ-12731)
The time zone lookup list (`partymgr/control/ListTimezones`) builds its display names with `TimeZone#getDisplayName(useDaylightTime(), LONG, locale)`. `useDaylightTime()` answers whether the zone *has* DST rules at all, not whether DST is currently in effect, so every DST-observing zone is permanently shown with its summer name — e.g. "British Summer Time" in December, or "Australian Eastern Daylight Time" during the southern winter. This is the remaining part of OFBIZ-12731 that Daniel noted after the footer was fixed.
This change uses the same `ZoneId#getDisplayName(TextStyle.FULL_STANDALONE, locale)` call the footer has used since OFBIZ-12721 (ca0433d0e4), so the list now shows the season-neutral generic name ("British Time", "Central European Time"). A nice side effect is that the list entries now match the name displayed in the footer — previously the footer name could not be found in the list, as Jacques noticed with "heure d'Europe centrale".
Verified on a local instance: the rendered page shows 631 zones with no "Summer Time"/"Daylight Time" variants remaining; Europe/London → "British Time", Australia/Sydney → "Eastern Australia Time" (the previous code shows "Australian Eastern Daylight Time" today, mid-southern-winter), Europe/Paris → "Central European Time".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Time zones always displayed using their daylight savings display name (OFBIZ-12731) [ofbiz-framework]
Posted by "toaditi (via GitHub)" <gi...@apache.org>.
toaditi closed pull request #1510: Fixed: Time zones always displayed using their daylight savings display name (OFBIZ-12731)
URL: https://github.com/apache/ofbiz-framework/pull/1510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Time zones always displayed using their daylight savings display name (OFBIZ-12731) [ofbiz-framework]
Posted by "toaditi (via GitHub)" <gi...@apache.org>.
toaditi commented on PR #1510:
URL: https://github.com/apache/ofbiz-framework/pull/1510#issuecomment-5115265040
Closing in favor of #1511 — the same change with a commit message that properly credits the prior work on the ticket by Daniel Watford, Eugen Stan and Jacques Le Roux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org