You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/26 07:44:54 UTC
[GitHub] [pinot] KKcorps commented on a diff in pull request #8774: Make row metadata available in Kafka 2.0 record ingestion
KKcorps commented on code in PR #8774:
URL: https://github.com/apache/pinot/pull/8774#discussion_r882406112
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelStreamConfig.java:
##########
@@ -31,13 +31,16 @@
*/
public class KafkaPartitionLevelStreamConfig {
+ public static final String POPULATE_ROW_METADATA = "stream.kafka.populateRowMetadata";
Review Comment:
Thanks a lot for the contribution!
We can document it here - https://docs.pinot.apache.org/configuration-reference/table. Also I think you just need to keep the property name as `populateRowMetadata`. The prefix is handled by pinot and can be changed in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org