You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/28 14:47:16 UTC
[GitHub] [kafka] rondagostino opened a new pull request #10604: MINOR: system test spelling/pydoc/dead code fixes
rondagostino opened a new pull request #10604:
URL: https://github.com/apache/kafka/pull/10604
Fixes some pydoc, corrects spelling, and removes dead code in system tests.
Renames `server_prop_overides` to `server_prop_overrides` to correct spelling.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on a change in pull request #10604: MINOR: system test spelling/pydoc/dead code fixes
Posted by GitBox <gi...@apache.org>.
rondagostino commented on a change in pull request #10604:
URL: https://github.com/apache/kafka/pull/10604#discussion_r622254888
##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -237,13 +237,14 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI
:param jmx_attributes:
:param int zk_connect_timeout:
:param int zk_session_timeout:
- :param dict server_prop_overides: overrides for kafka.properties file
+ :param list[list] server_prop_overrides: overrides for kafka.properties file
+ e.g: [["config1", "true"], ["config2", "1000"]]
:param str zk_chroot:
:param bool zk_client_secure: connect to Zookeeper over secure client port (TLS) when True
:param ListenerSecurityConfig listener_security_config: listener config to use
- :param dict per_node_server_prop_overrides: overrides for kafka.properties file keyed by 0-based node number
+ :param dict per_node_server_prop_overrides: overrides for kafka.properties file keyed by 1-based node number
+ e.g: {1: [["config1", "true"], ["config2", "1000"]], 2: [["config1", "false"], ["config2", "0"]]}
:param str extra_kafka_opts: jvm args to add to KAFKA_OPTS variable
- :param str tls_version: TLS version to use
Review comment:
This already exists above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10604: MINOR: system test spelling/pydoc/dead code fixes
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10604:
URL: https://github.com/apache/kafka/pull/10604#issuecomment-829572710
> Could you also update the "Co-located Raft quorum" comment in the init section with starting node id as 1?
Nice catch, @kamalcph! I think I fixed what you were referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #10604: MINOR: system test spelling/pydoc/dead code fixes
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10604:
URL: https://github.com/apache/kafka/pull/10604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org