You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 17:27:45 UTC
[GitHub] [arrow] wjones127 opened a new pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original [WIP]
wjones127 opened a new pull request #11727:
URL: https://github.com/apache/arrow/pull/11727
Got a test reproducing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #11727:
URL: https://github.com/apache/arrow/pull/11727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-982148664
Benchmark runs are scheduled for baseline = b83e6b098fef8867d919f2bd4ac72637a31b8ded and contender = debf48d38fefc9c9b8f7c1c7b78b1d51fc577638. debf48d38fefc9c9b8f7c1c7b78b1d51fc577638 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a42828b72544142b74f68be263b09b3...2c7c58bb8ce9428cb7da317bd188d296/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/775cf0bbdadb4d20920774e622c58d0f...d4d093b5cfdb4e9b9670ade130b1e349/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8d7ed0f514ee4976bf6a177d3aa1b7d8...68fb837718e642dba49a93f0b1413eda/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romainfrancois commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original [WIP]
Posted by GitBox <gi...@apache.org>.
romainfrancois commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-972755825
Should be fixed now. For the record, the relevant R code: https://github.com/r-devel/r-svn/blob/1a9b0f70744608548b8d6e7869c3930e3881edab/src/main/arithmetic.c#L793
```c
static SEXP integer_unary(ARITHOP_TYPE code, SEXP s1, SEXP call)
{
R_xlen_t i, n;
SEXP ans;
switch (code) {
case PLUSOP:
return s1;
case MINUSOP:
ans = NO_REFERENCES(s1) ? s1 : duplicate(s1);
int *pa = INTEGER(ans);
const int *px = INTEGER_RO(s1);
n = XLENGTH(s1);
for (i = 0; i < n; i++) {
int x = px[i];
pa[i] = (x == NA_INTEGER) ?
NA_INTEGER : ((x == 0.0) ? 0 : -x);
}
return ans;
default:
errorcall(call, _("invalid unary operator"));
}
return s1; /* never used; to keep -Wall happy */
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-979110684
@ursabot please benchmark lang=R
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-972847800
Removed "WIP" in title to un-skip CI builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-982148664
Benchmark runs are scheduled for baseline = b83e6b098fef8867d919f2bd4ac72637a31b8ded and contender = debf48d38fefc9c9b8f7c1c7b78b1d51fc577638. debf48d38fefc9c9b8f7c1c7b78b1d51fc577638 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a42828b72544142b74f68be263b09b3...2c7c58bb8ce9428cb7da317bd188d296/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/775cf0bbdadb4d20920774e622c58d0f...d4d093b5cfdb4e9b9670ade130b1e349/)
[Finished :arrow_down:1.02% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8d7ed0f514ee4976bf6a177d3aa1b7d8...68fb837718e642dba49a93f0b1413eda/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-971797964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] romainfrancois commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original [WIP]
Posted by GitBox <gi...@apache.org>.
romainfrancois commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-972709809
Thanks @wjones127 I'm on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-982148664
Benchmark runs are scheduled for baseline = b83e6b098fef8867d919f2bd4ac72637a31b8ded and contender = debf48d38fefc9c9b8f7c1c7b78b1d51fc577638. debf48d38fefc9c9b8f7c1c7b78b1d51fc577638 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a42828b72544142b74f68be263b09b3...2c7c58bb8ce9428cb7da317bd188d296/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/775cf0bbdadb4d20920774e622c58d0f...d4d093b5cfdb4e9b9670ade130b1e349/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8d7ed0f514ee4976bf6a177d3aa1b7d8...68fb837718e642dba49a93f0b1413eda/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-979111103
Benchmark runs are scheduled for baseline = 34b860463d2c50bc2262fc8c8fa57ec5c89b2896 and contender = 68534040f97b73483b9f9f19e9abda1b107a9e3e. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/026b491a33124ba9bb3873f83d4bc180...3d88800f76294912a42a810203754316/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5d9991a463b84020931c687da1f4e165...95a4914d40fd4a4bb21733e3e7da1de2/)
[Skipped :warning: Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9440c5f6bcb54b9ba694bc1694282715...522ec66a83e54a23a7e4ab1050525ed3/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-982148664
Benchmark runs are scheduled for baseline = b83e6b098fef8867d919f2bd4ac72637a31b8ded and contender = debf48d38fefc9c9b8f7c1c7b78b1d51fc577638. debf48d38fefc9c9b8f7c1c7b78b1d51fc577638 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a42828b72544142b74f68be263b09b3...2c7c58bb8ce9428cb7da317bd188d296/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/775cf0bbdadb4d20920774e622c58d0f...d4d093b5cfdb4e9b9670ade130b1e349/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8d7ed0f514ee4976bf6a177d3aa1b7d8...68fb837718e642dba49a93f0b1413eda/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original [WIP]
Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-971947395
@romainfrancois Got a test reproducing the bug, but not sure where the `-b_int` is actually dispatching to. You have an idea on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #11727:
URL: https://github.com/apache/arrow/pull/11727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-982135352
This should be ready to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-979110177
Should this be merged? Also cc @jonkeane @thisisnic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11727: ARROW-14722: [R] Fix altrep vector negation modifying original
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11727:
URL: https://github.com/apache/arrow/pull/11727#issuecomment-979111103
Benchmark runs are scheduled for baseline = 34b860463d2c50bc2262fc8c8fa57ec5c89b2896 and contender = 68534040f97b73483b9f9f19e9abda1b107a9e3e. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/026b491a33124ba9bb3873f83d4bc180...3d88800f76294912a42a810203754316/)
[Failed :arrow_down:2.6% :arrow_up:0.43%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5d9991a463b84020931c687da1f4e165...95a4914d40fd4a4bb21733e3e7da1de2/)
[Skipped :warning: Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9440c5f6bcb54b9ba694bc1694282715...522ec66a83e54a23a7e4ab1050525ed3/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org