You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/03/01 08:03:49 UTC
[GitHub] walking98 commented on a change in pull request #49: [ISSUE-41]
Optimize header conversion
walking98 commented on a change in pull request #49: [ISSUE-41] Optimize header conversion
URL: https://github.com/apache/rocketmq-spring/pull/49#discussion_r261508338
##########
File path: rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/support/RocketMQUtil.java
##########
@@ -73,37 +76,44 @@ public static MessagingException convert(MQClientException e) {
public static org.springframework.messaging.Message convertToSpringMessage(
org.apache.rocketmq.common.message.MessageExt message) {
- org.springframework.messaging.Message retMessage =
+ MessageBuilder messageBuilder =
MessageBuilder.withPayload(message.getBody()).
- setHeader(RocketMQHeaders.KEYS, message.getKeys()).
- setHeader(RocketMQHeaders.TAGS, message.getTags()).
- setHeader(RocketMQHeaders.TOPIC, message.getTopic()).
- setHeader(RocketMQHeaders.MESSAGE_ID, message.getMsgId()).
- setHeader(RocketMQHeaders.BORN_TIMESTAMP, message.getBornTimestamp()).
- setHeader(RocketMQHeaders.BORN_HOST, message.getBornHostString()).
- setHeader(RocketMQHeaders.FLAG, message.getFlag()).
- setHeader(RocketMQHeaders.QUEUE_ID, message.getQueueId()).
- setHeader(RocketMQHeaders.SYS_FLAG, message.getSysFlag()).
- setHeader(RocketMQHeaders.TRANSACTION_ID, message.getTransactionId()).
- setHeader(RocketMQHeaders.PROPERTIES, message.getProperties()).
- build();
-
- return retMessage;
+ setHeader(RocketMQHeaders.PREFIX + RocketMQHeaders.KEYS, message.getKeys()).
Review comment:
This behavior change needs a release note for backward compatible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services