You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@hotwaxmedia.com> on 2011/03/08 17:10:47 UTC
Re: svn commit: r1079307 - in /ofbiz/trunk/applications: order/script/org/ofbiz/order/olap/ order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ product/config/ product/data/ product/script/org/ofbiz/product/category/ product/script/org/ofbiz/product/produ...
Hi Hans,
could you please help me to understand the change you did to FactServices? It doesn't seem to be related to the commit log:
"It is now possible to manually override the automatic generated page meta description, keywords and title in the content tab in product and category. Also ecommerce component has been adapted. A contribution of AntWebsystems employee Tom"
Was it a change not intended to be committed?
Kind regards,
Jacopo
On Mar 8, 2011, at 10:35 AM, hansbak@apache.org wrote:
>
> Modified: ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml?rev=1079307&r1=1079306&r2=1079307&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml (original)
> +++ ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml Tue Mar 8 09:35:20 2011
> @@ -152,7 +152,20 @@ under the License.
> <result-to-field result-name="dimensionId" field="fact.productDimId"/>
> </call-service>
> <if-empty field="fact.productDimId">
> - <set field="fact.productDimId" value="_NF_"/>
> + <entity-one entity-name="Product" value-field="productDim">
> + <field-map field-name="productId" from-field="orderItem.productId"/>
> + </entity-one>
> + <make-value entity-name="ProductDimension" value-field="newEntity"/>
> + <sequenced-id sequence-name="ProductDimension" field="newEntity.dimensionId"/>
> + <set field="newEntity.productId" from-field="productDim.productId"/>
> + <set field="newEntity.productType" from-field="productDim.productTypeId"/>
> + <set field="newEntity.brandName" from-field="productDim.brandName"/>
> + <set field="newEntity.internalName" from-field="productDim.internalName"/>
> + <create-value value-field="newEntity"/>
> + <set field="fact.productDimId" from-field="newEntity.dimensionId"/>
> + <if-empty field="fact.productDimId">
> + <set field="fact.productDimId" value="_NF_"/>
> + </if-empty>
> </if-empty>
> <else>
> <set field="fact.productDimId" value="_NA_"/>
Re: svn commit: r1079307 - in /ofbiz/trunk/applications:
order/script/org/ofbiz/order/olap/
order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ product/config/
product/data/ product/script/org/ofbiz/product/category/
product/script/org/ofbiz/product/produ...
Posted by Hans Bakker <ma...@antwebsystems.com>.
Thank you Jacopo for spotting this,
reverted in revision 1080107.
Regards,
Hans
On Tue, 2011-03-08 at 17:10 +0100, Jacopo Cappellato wrote:
> Hi Hans,
>
> could you please help me to understand the change you did to FactServices? It doesn't seem to be related to the commit log:
> "It is now possible to manually override the automatic generated page meta description, keywords and title in the content tab in product and category. Also ecommerce component has been adapted. A contribution of AntWebsystems employee Tom"
>
> Was it a change not intended to be committed?
>
> Kind regards,
>
> Jacopo
>
> On Mar 8, 2011, at 10:35 AM, hansbak@apache.org wrote:
>
> >
> > Modified: ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml?rev=1079307&r1=1079306&r2=1079307&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml (original)
> > +++ ofbiz/trunk/applications/order/script/org/ofbiz/order/olap/FactServices.xml Tue Mar 8 09:35:20 2011
> > @@ -152,7 +152,20 @@ under the License.
> > <result-to-field result-name="dimensionId" field="fact.productDimId"/>
> > </call-service>
> > <if-empty field="fact.productDimId">
> > - <set field="fact.productDimId" value="_NF_"/>
> > + <entity-one entity-name="Product" value-field="productDim">
> > + <field-map field-name="productId" from-field="orderItem.productId"/>
> > + </entity-one>
> > + <make-value entity-name="ProductDimension" value-field="newEntity"/>
> > + <sequenced-id sequence-name="ProductDimension" field="newEntity.dimensionId"/>
> > + <set field="newEntity.productId" from-field="productDim.productId"/>
> > + <set field="newEntity.productType" from-field="productDim.productTypeId"/>
> > + <set field="newEntity.brandName" from-field="productDim.brandName"/>
> > + <set field="newEntity.internalName" from-field="productDim.internalName"/>
> > + <create-value value-field="newEntity"/>
> > + <set field="fact.productDimId" from-field="newEntity.dimensionId"/>
> > + <if-empty field="fact.productDimId">
> > + <set field="fact.productDimId" value="_NF_"/>
> > + </if-empty>
> > </if-empty>
> > <else>
> > <set field="fact.productDimId" value="_NA_"/>
>
--
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.