You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "masayag (via GitHub)" <gi...@apache.org> on 2025/05/06 13:44:00 UTC
[I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
masayag opened a new issue, #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112
The `kn-workflow` already supports generating k8s manifests for deployment on cluster with `gitops` profile.
With `gitops` profile it is expected for the user to specify the image to use and for the user to be responsible for building the image.
However, there is no direct reference to how to build that image, e.g. which builder image to use for the specific version compatible with kn-workflow and also which Dockerfile to use.
The kn-workflow can provide that information by offering the same Dockerfile and steps on how to use it, e.g.:
- By adding a flag to enable persistence, the user will get the required QUARKUS_EXTENSION to use which contains the persistence support compatible with that version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-2859654120
> > I prefer --gitops-profile because it won’t give end users the misleading impression that other profiles include special functionality.
>
> But in the future we might have :)
or might not :)
I’m not one to optimize before it’s necessary :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "masayag (via GitHub)" <gi...@apache.org>.
masayag commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-2854637693
cc @ricardozanini
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-2987078488
I think it's worth separating the two use cases:
Quarkus project with persistence
Simple project with persistence
I believe this makes sense because in the Quarkus case, the user is expected to build and publish a Docker image themselves. In contrast, when using the sonataflow-builder, there's no need to create a Quarkus project beforehand. A Dockerfile with the appropriate Quarkus extensions and additional environment variables is sufficient.
In my view, this significantly simplifies working with GitOps persistence apps.
@masayag @ricardozanini
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel closed issue #3112: [kn-workflow] Provide an option to generate build resources for gitops profile
URL: https://github.com/apache/incubator-kie-tools/issues/3112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-3001974047
> > there's no need to create a Quarkus project beforehand.
>
> For local development it is needed. IIUC, the entire concept of gitops profile is for deployment, hence the generated CRs and a Dockerfile to ease the build of the workflow are needed. Also for development persistence isn't needed (most of the time, IINW).
There are two options atm:
1) for local dev (quarkus + extension + vars)
kn workflow quarkus create --with-persistance --profile=gitops
2) workflow + Dockerfile with extension and vars
kn workflow create --with-persistence
Looks like it covers all cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-2855058387
@treblereel can you evaluate this one and add to our Q2 epic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-2859188538
After discussing with masayag, we’ve decided to add to `quarkus create` the ability to generate additional GitOps functionality via an extra argument.
The idea is to introduce a profile flag:
```
--profile=gitops or --gitops-profile
```
I prefer `--gitops-profile` because it won’t give end users the misleading impression that other profiles include special functionality.
And additionally:
```
--with-persistence
```
@masayag @ricardozanini
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-3037027560
merged https://github.com/apache/incubator-kie-tools/commit/b6658df8b9f187c0c5fdecfc6517a640d823823f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-2859286848
> I prefer --gitops-profile because it won’t give end users the misleading impression that other profiles include special functionality.
But in the future we might have :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [I] [kn-workflow] Provide an option to generate build resources for gitops profile [incubator-kie-tools]
Posted by "masayag (via GitHub)" <gi...@apache.org>.
masayag commented on issue #3112:
URL: https://github.com/apache/incubator-kie-tools/issues/3112#issuecomment-3000665123
> there's no need to create a Quarkus project beforehand.
For local development it is needed.
IIUC, the entire concept of gitops profile is for deployment, hence the generated CRs and a Dockerfile to ease the build of the workflow are needed.
Also for development persistence isn't needed (most of the time, IINW).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org