You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Timothy Chen <tn...@apache.org> on 2014/04/03 02:34:38 UTC

Review Request 19972: Patch for KAFKA-1358

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19972/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1358
    https://issues.apache.org/jira/browse/KAFKA-1358


Repository: kafka


Description
-------

KAFKA-1358 Only shutdown delete topic manager if initialized on reinit zk session


Diffs
-----

  core/src/main/scala/kafka/controller/KafkaController.scala d142f8c1859bfb8660a399dca16ffebdc30d8365 

Diff: https://reviews.apache.org/r/19972/diff/


Testing
-------


Thanks,

Timothy Chen

Re: Review Request 19972: Patch for KAFKA-1358

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19972/#review39401
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On April 3, 2014, 12:34 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19972/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 12:34 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1358
>     https://issues.apache.org/jira/browse/KAFKA-1358
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1358 Only shutdown delete topic manager if initialized on reinit zk session
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala d142f8c1859bfb8660a399dca16ffebdc30d8365 
> 
> Diff: https://reviews.apache.org/r/19972/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 19972: Patch for KAFKA-1358

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19972/#review39384
-----------------------------------------------------------

Ship it!



core/src/main/scala/kafka/controller/KafkaController.scala
<https://reviews.apache.org/r/19972/#comment71783>

    Minor comment - this info statement is probably removed accidentally. Will keep it during checkin


- Neha Narkhede


On April 3, 2014, 12:34 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19972/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 12:34 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1358
>     https://issues.apache.org/jira/browse/KAFKA-1358
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1358 Only shutdown delete topic manager if initialized on reinit zk session
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala d142f8c1859bfb8660a399dca16ffebdc30d8365 
> 
> Diff: https://reviews.apache.org/r/19972/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>