You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/30 06:17:39 UTC

[GitHub] [apisix] bisakhmondal commented on pull request #6232: feat(discovery): add consul support

bisakhmondal commented on pull request #6232:
URL: https://github.com/apache/apisix/pull/6232#issuecomment-1025079606


   > @bisakhmondal Could you help @water1st if she/he has trouble with the test cases? Thanks!
   
   Hi @water1st, for the code lint: you can run `make lint` before pushing your changes to the PR ([ref](https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#check-code-style-and-test-case-style))
   
   As you have created a new directory (/discovey/consul), it won't be installed automatically unless you add an entry here. could you please do it? The other CIs will also pass after that.
   https://github.com/apache/apisix/blob/bbebdc9606e47f325180737cabf3cf479b69d013/Makefile#L275-L282 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org