[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2341: Add public Serialization/Deserialization API to/from bytes

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2341:
URL: https://github.com/apache/arrow-datafusion/pull/2341#discussion_r859084289


##########
datafusion/core/src/prelude.rs:
##########
@@ -36,5 +36,5 @@ pub use crate::logical_plan::{
     in_list, initcap, left, length, lit, lower, lpad, ltrim, max, md5, min, now,
     octet_length, random, regexp_match, regexp_replace, repeat, replace, reverse, right,
     rpad, rtrim, sha224, sha256, sha384, sha512, split_part, starts_with, strpos, substr,
-    sum, to_hex, translate, trim, upper, Column, JoinType, Partitioning,
+    sum, to_hex, translate, trim, upper, Column, Expr, JoinType, Partitioning,

Review Comment:
   The lack of `Expr` in the prelude has always surprised me. I will make a separate PR for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org