You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/03/28 04:18:51 UTC
Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS`
agent API call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Bugs: MESOS-8745
https://issues.apache.org/jira/browse/MESOS-8745
Repository: mesos
Description
-------
`LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
provider configs from the resource provider config directory, except
for the ones that are placed out-of-band.
Diffs
-----
include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
Diff: https://reviews.apache.org/r/66327/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 66327: WIP: Added the
`LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/#review200125
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66318', '66325', '66326', '66327']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (108 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1059 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (828 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (852 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (834 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (859 ms total)
[----------] Global test environment tear-down
[==========] 949 tests from 94 test cases ran. (440792 ms total)
[ PASSED ] 948 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 214 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327/logs/mesos-tests-stderr.log):
```
I0328 18:14:06.345139 6924 exec.cpp:236] Executor registered on agent ae756040-1f28-4741-b582-c62b863eb4e9-S0
I0328 18:14:06.349126 5368 executor.cpp:176] Received SUBSCRIBED event
I0328 18:14:06.354125 5368 executor.cpp:180] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0328 18:14:06.354125 5368 executor.cpp:176] Received LAUNCH event
I0328 18:14:06.360126 5368 executor.cpp:648] Starting task 65e2147b-4450-4bed-8115-42fb849da4a5
I0328 18:14:06.451171 5368 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0328 18:14:06.478179 5368 executor.cpp:661] Forked command at 1568
I0328 18:14:06.509186 1176 exec.cpp:445] Executor asked to shutdown
I0328 18:14:06.510143 6392 executor.cpp:176] Received SHUTDOWN event
I0328 18:14:06.510143 6392 executor.cpp:758] Shutting down
I0328 18:14:06.510143 6392 executor.cpp:868] Sending SIGTERM to process tree at pid 1.507169 8216 hierarchical.cpp:405] Deactivated framework ae756040-1f28-4741-b582-c62b863eb4e9-0000
I0328 18:14:06.507169 3376 slave.cpp:3873] Shutting down framework ae756040-1f28-4741-b582-c62b863eb4e9-0000
I0328 18:14:06.507169 7824 master.cpp:10446] Updating the state of task 65e2147b-4450-4bed-8115-42fb849da4a5 of framework ae756040-1f28-4741-b582-c62b863eb4e9-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0328 18:14:06.507169 3376 slave.cpp:6566] Shutting down executor '65e2147b-4450-4bed-8115-42fb849da4a5' of framework ae756040-1f28-4741-b582-c62b863eb4e9-0000 at executor(1)@10.3.1.8:54008
I0328 18:14:06.508146 3376 slave.cpp:919] Agent terminating
W0328 18:14:06.508146 3376 slave.cpp:3869] Ignoring shutdown framework ae756040-1f28-4741-b582-c62b863eb4e9-0000 because it is terminating
I0328 18:14:06.510143 7824 master.cpp:10545] Removing task 65e2147b-4450-4bed-8115-42fb849da4a5 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework ae756040-1f28-4741-b582-c62b863eb4e9-0000 on agent ae756040-1f28-4741-b582-c62b863eb4e9-S0 at slave(418)@10.3.1.8:53987 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 18:14:06.512130 3376 containerizer.cpp:2338] Destroying container 1fc35e64-161b-48ec-8ce1-f6f039c17993 in RUNNING state
I0328 18:14:06.512130 3376 containerizer.cpp:2952] Transitioning the state of container 1fc35e64-161b-48ec-8ce1-f6f039c17993 from RUNNING to DESTROYING
I0328 18:14:06.513144 3376 launcher.cpp:156] Asked to destroy container 1fc35e64-161b-48ec-8ce1-f6f039c17993
I0328 18:14:06.514144 7864 hierarchical.cpp:344] Removed framework ae756040-1f28-4741-b582-c62b863eb4e9-0000
I0328 18:14:06.514144 7824 master.cpp:1295] Agent ae756040-1f28-4741-b582-c62b863eb4e9-S0 at slave(418)@10.3.1.8:53987 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0328 18:14:06.514144 7824 master.cpp:3283] Disconnecting agent ae756040-1f28-4741-b582-c62b863eb4e9-S0 at slave(418)@10.3.1.8:53987 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 18:14:06.514144 7824 master.cpp:3302] Deactivating agent ae756040-1f28-4741-b582-c62b863eb4e9-S0 at slave(418)@10.3.1.8:53987 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0328 18:14:06.515143 4344 hierarchical.cpp:766] Agent ae756040-1f28-4741-b582-c62b863eb4e9-S0 deactivated
I0328 18:14:06.586320 1296 containerizer.cpp:2791] Container 1fc35e64-161b-48ec-8ce1-f6f039c17993 has exited
I0328 18:14:06.618317 9004 master.cpp:1137] Master terminating
I0328 18:14:06.621354 3376 hierarchical.cpp:609] Removed agent ae756040-1f28-4741-b582-c62b863eb4e9-S0
I0328 18:14:06.994926 7412 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 28, 2018, 4:18 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66327/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 4:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8745
> https://issues.apache.org/jira/browse/MESOS-8745
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
> provider configs from the resource provider config directory, except
> for the ones that are placed out-of-band.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
> include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
>
>
> Diff: https://reviews.apache.org/r/66327/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66327: WIP: Added the
`LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/#review200096
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66318', '66325', '66326', '66327']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (16) ->
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [D:\DCOS\mesos\src\mesos-protobufs.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:01:25.63
```
- Mesos Reviewbot Windows
On March 28, 2018, 4:18 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66327/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 4:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8745
> https://issues.apache.org/jira/browse/MESOS-8745
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
> provider configs from the resource provider config directory, except
> for the ones that are placed out-of-band.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
> include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
>
>
> Diff: https://reviews.apache.org/r/66327/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66327: WIP: Added the
`LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/#review200095
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66318', '66325', '66326', '66327']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos-protobufs.vcxproj" (default target) (16) ->
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [D:\DCOS\mesos\src\mesos-protobufs.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:00:58.62
```
- Mesos Reviewbot Windows
On March 28, 2018, 4:18 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66327/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 4:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8745
> https://issues.apache.org/jira/browse/MESOS-8745
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
> provider configs from the resource provider config directory, except
> for the ones that are placed out-of-band.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
> include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
>
>
> Diff: https://reviews.apache.org/r/66327/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66327: WIP: Added the
`LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/#review213342
-----------------------------------------------------------
Bad review!
Reviews applied: [66327, 66326, 66325, 66318]
Error:
2019-03-02 04:26:42 URL:https://reviews.apache.org/r/66327/diff/raw/ [7620/7620] -> "66327.patch" [1]
error: patch failed: include/mesos/agent/agent.proto:97
error: include/mesos/agent/agent.proto: patch does not apply
error: patch failed: include/mesos/v1/agent/agent.proto:97
error: include/mesos/v1/agent/agent.proto: patch does not apply
- Mesos Reviewbot
On March 28, 2018, 10:22 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66327/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 10:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8745
> https://issues.apache.org/jira/browse/MESOS-8745
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
> provider configs from the resource provider config directory, except
> for the ones that are placed out-of-band.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
> include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
>
>
> Diff: https://reviews.apache.org/r/66327/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66327: WIP: Added the
`LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/#review200169
-----------------------------------------------------------
PASS: Mesos patch 66327 was successfully built and tested.
Reviews applied: `['66318', '66325', '66326', '66327']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66327
- Mesos Reviewbot Windows
On March 28, 2018, 3:22 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66327/
> -----------------------------------------------------------
>
> (Updated March 28, 2018, 3:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-8745
> https://issues.apache.org/jira/browse/MESOS-8745
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
> provider configs from the resource provider config directory, except
> for the ones that are placed out-of-band.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
> include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
>
>
> Diff: https://reviews.apache.org/r/66327/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66327: WIP: Added the
`LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66327/
-----------------------------------------------------------
(Updated March 28, 2018, 10:22 p.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
Bugs: MESOS-8745
https://issues.apache.org/jira/browse/MESOS-8745
Repository: mesos
Description
-------
`LIST_RESOURCE_PROVIDER_CONFIGS` returns a list of all valid resource
provider configs from the resource provider config directory, except
for the ones that are placed out-of-band.
Diffs (updated)
-----
include/mesos/agent/agent.proto adaccb3509fdfc1e7cac9482e93a91e83bc5625d
include/mesos/v1/agent/agent.proto 71352a79fe7d28d633a4badceafe18086c1e5ab7
Diff: https://reviews.apache.org/r/66327/diff/4/
Changes: https://reviews.apache.org/r/66327/diff/3-4/
Testing
-------
Thanks,
Chun-Hung Hsiao