You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/23 01:51:10 UTC
Review Request 71140: Fixed devolution of 'max_grace_period' field in
DRAIN_AGENT call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71140/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone.
Repository: mesos
Description
-------
Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.
Diffs
-----
src/internal/devolve.cpp 2809c25fcf972e8a22528e55cd439dd64bd04dbb
src/tests/api_tests.cpp 3479ed31e9cbbe4b61a4fe092b684677f488c621
Diff: https://reviews.apache.org/r/71140/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 71140: Fixed devolution of 'max_grace_period'
field in DRAIN_AGENT call.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71140/#review216795
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 22, 2019, 6:51 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71140/
> -----------------------------------------------------------
>
> (Updated July 22, 2019, 6:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.
>
>
> Diffs
> -----
>
> src/internal/devolve.cpp 2809c25fcf972e8a22528e55cd439dd64bd04dbb
> src/tests/api_tests.cpp 3479ed31e9cbbe4b61a4fe092b684677f488c621
>
>
> Diff: https://reviews.apache.org/r/71140/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 71140: Fixed devolution of 'max_grace_period'
field in DRAIN_AGENT call.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71140/#review216798
-----------------------------------------------------------
Bad review!
Reviews applied: [71140]
Error:
2019-07-23 09:08:30 URL:https://reviews.apache.org/r/71140/diff/raw/ [1871/1871] -> "71140.patch" [1]
error: patch failed: src/internal/devolve.cpp:280
error: src/internal/devolve.cpp: patch does not apply
error: patch failed: src/tests/api_tests.cpp:5588
error: src/tests/api_tests.cpp: patch does not apply
- Mesos Reviewbot
On July 23, 2019, 1:51 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71140/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 1:51 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed devolution of 'max_grace_period' field in DRAIN_AGENT call.
>
>
> Diffs
> -----
>
> src/internal/devolve.cpp 2809c25fcf972e8a22528e55cd439dd64bd04dbb
> src/tests/api_tests.cpp 3479ed31e9cbbe4b61a4fe092b684677f488c621
>
>
> Diff: https://reviews.apache.org/r/71140/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>