[GitHub] lanking520 edited a comment on issue #12489: [WIP][MXNET-918] Random api

[GitBox <gi...@apache.org>]

lanking520 edited a comment on issue #12489: [WIP][MXNET-918] Random api
URL: https://github.com/apache/incubator-mxnet/pull/12489#issuecomment-433469267
 
 
   @mdespriee thanks for your effort to refactor the code and I really appreciate your time spent on it.  The issue shown above is the mismatch on the parameter. It can be caused by `function name` do not have this parameter, or you put a param in the wrong type. I would recommend you to split the refactoring portion and Random generation portion into two PRs. The good thing: 
   
   1. you can focus on each of them and make the refactoring and Random part even better. 
   
   2. Reduce the change on your code, it's easier for you to find where the problem is and easy for us to help you find where you can make a mistake.
   
   3. The change you have introduced is too big, it both influence the old code generation and the new feature generation. A lot of tests and verification has to be done before we merge the code. This can take a while... 
   
   I know this may introduce more work to you but I think this could be the best solution.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services