You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by KurtYoung <gi...@git.apache.org> on 2017/01/13 10:57:06 UTC

[GitHub] flink pull request #3040: [FLINK-3850] Add forward field annotations to Data...

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3040#discussion_r95975427
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala ---
    @@ -129,8 +131,35 @@ class DataSetCalc(
           body,
           returnType)
     
    +    def getForwardIndices = {
    +      //get indices of all modified operands
    +      val modifiedOperands = calcProgram.
    +        getExprList
    +        .filter(_.isInstanceOf[RexCall])
    +        .flatMap(_.asInstanceOf[RexCall].operands)
    +        .map(_.asInstanceOf[RexLocalRef].getIndex)
    --- End diff --
    
    Shouldn't the modified fields are meaning to the input fields? So it should be RexInputRef?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---