You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/09 14:16:21 UTC

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

    [ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322577#comment-15322577 ] 

ASF GitHub Bot commented on FLINK-3859:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2088

    [FLINK-3859] [table] Add BigDecimal/BigInteger support to Table API

    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR introduces the BigDecimal type (and thus also BigInteger) to the Table API. Basic arithmetic operations as well as ABS, FLOOR and CEIL are now possible. I fixed several bugs and refactored some code parts (e.g. I introduced an ExpressionTestBase). 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink TableApiBigDecBigIntIntegration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2088.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2088
    
----
commit 79ebde101c48f5718a35638283d5e953a3b0bb0e
Author: twalthr <tw...@apache.org>
Date:   2016-05-09T10:10:57Z

    [FLINK-3859] [table] Add BigDecimal/BigInteger support to Table API

----


> Add BigDecimal/BigInteger support to Table API
> ----------------------------------------------
>
>                 Key: FLINK-3859
>                 URL: https://issues.apache.org/jira/browse/FLINK-3859
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Critical
>
> Since FLINK-3786 has been solved, we can now start integrating BigDecimal/BigInteger into the Table API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)