[GitHub] [netbeans] asbachb commented on pull request #5505: Pattern normalization: "[A-Za-z0-9_]" to "\w". Multicommit. Jmh

["asbachb (via GitHub)" <gi...@apache.org>]

asbachb commented on PR #5505:
URL: https://github.com/apache/netbeans/pull/5505#issuecomment-1433257817

   I slightly agree with @matthiasblaesing 
   
   If you don't know regex, you might still understand whats `[A-Za-z0-9_]` with `\w` you most likely need to look up which characters are included exactly.
   
   @tbw777 if you run the same test per pattern twice is the output of both runs most likely equal?
   
   e.g.
   
   ```
   Regexps.testMatchLong         [A-Z_0-9a-z]  100000  thrpt       45397874,174          ops/s
   Regexps.testMatchLong         [A-Z_0-9a-z]  100000  thrpt       45397874,174          ops/s
   ```
   
   have you disabled jit for the benchmarks?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists