[GitHub] [iceberg] rdblue commented on a change in pull request #1920: Hive: Serialize metadata location so split generation does not need to load the table

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1920:
URL: https://github.com/apache/iceberg/pull/1920#discussion_r551459563



##########
File path: core/src/main/java/org/apache/iceberg/BaseTable.java
##########
@@ -30,13 +32,12 @@
  * <p>
  * This can be extended by providing a {@link TableOperations} to the constructor.
  */
-public class BaseTable implements Table, HasTableOperations {
-  private final TableOperations ops;
-  private final String name;
+public class BaseTable implements Table, HasTableOperations, Serializable {
+  private transient TableOperations ops;
+  private transient String name;

Review comment:
       These shouldn't need to change if `writeReplace` is implemented. This object won't be serialized, it will be replaced by the one to serialize.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org