[GitHub] gianm commented on a change in pull request #6617: Fix bugs in ExprEval

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6617: Fix bugs in ExprEval
URL: https://github.com/apache/incubator-druid/pull/6617#discussion_r233195034
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/math/expr/ExprEval.java
 ##########
 @@ -197,7 +197,7 @@ public final ExprEval castTo(ExprType castTo)
           return this;
         case LONG:
           if (value == null) {
-            return ExprEval.of(null);
+            return ExprEval.ofLong(null);
 
 Review comment:
   What do you think about moving ExprEval.of(long) and ExprEval.ofLong(Number) to LongExprEval and calling them LongExprEval.of and LongExprEval.ofBoxed? It might make the code easier to understand and less prone to programmer error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org