You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "flora-jin (via GitHub)" <gi...@apache.org> on 2025/02/10 22:43:57 UTC
[PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
flora-jin opened a new pull request, #3030:
URL: https://github.com/apache/tinkerpop/pull/3030
Tinkerpop: https://issues.apache.org/jira/browse/TINKERPOP-3024
has_key_() was added to python because it was reserved on Dictionary but that was removed in python 3. since TinkerPop doesn't support python 2 anymore there is little need for this difference anymore. deprecate the underscore suffixed version and add the property has_key() version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2649456739
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 76.35%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`31ea03d`)](https://app.codecov.io/gh/apache/tinkerpop/commit/31ea03d4722bd1a17be66f752c744addaef71294?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 311 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #3030 +/- ##
=============================================
+ Coverage 76.14% 76.35% +0.21%
- Complexity 13152 13229 +77
=============================================
Files 1084 1061 -23
Lines 65160 61567 -3593
Branches 7285 7342 +57
=============================================
- Hits 49616 47012 -2604
+ Misses 12839 12034 -805
+ Partials 2705 2521 -184
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3030?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on code in PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#discussion_r1951361131
##########
gremlin-python/src/main/python/gremlin_python/process/graph_traversal.py:
##########
@@ -2485,7 +2502,9 @@ def where(*args):
statics.add_static('hasKey', hasKey)
-statics.add_static('has_key', has_key_)
+statics.add_static('has_key_', has_key_)
Review Comment:
I don't think you need to add this static import to the deprecated `has_key_`, you can just change the existing static `has_key` to point to the new `has_key` instead of the deprecated `has_key_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2657214173
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2652082264
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2657343601
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2657187766
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2652133352
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3024] Deprecate has_key_() for has_key() in python [tinkerpop]
Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3030:
URL: https://github.com/apache/tinkerpop/pull/3030#issuecomment-2651657259
I see a reference to `has_key_` in gremlin-variants.asciidoc` that should be removed:
```
In situations where Python reserved words and global functions overlap with standard Gremlin steps and tokens, those
bits of conflicting Gremlin get an underscore appended as a suffix:
*Steps* - <<all-step,all_()>>, <<and-step,and_()>>, <<any-step,any_()>>, <<as-step,as_()>>, <<filter-step,filter_()>>, <<from-step,from_()>>,
<<has-step,has_key_>>, <<id-step,id_()>>, <<is-step,is_()>>, <<in-step,in_()>>, <<max-step,max_()>>,
<<min-step,min_()>>, <<not-step,not_()>>, <<or-step,or_()>>, <<range-step,range_()>>, <<sum-step,sum_()>>,
<<with-step,with_()>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org