You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by bo...@apache.org on 2022/09/02 11:06:14 UTC
[impala] 03/05: IMPALA-11543: Print exception message even if throwable_to_stack_trace_id fails
This is an automated email from the ASF dual-hosted git repository.
boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit c1bf0af35bf3314c305711dde778038f6df55a82
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Tue Aug 30 17:43:32 2022 +0200
IMPALA-11543: Print exception message even if throwable_to_stack_trace_id fails
Until now if we got the message but not the callstack, we did
not print the message, only a generic one about suspecting OOM.
Testing:
- tested manually by throwing an exception from throwableToStackTrace
Change-Id: Ia7d08abb685e687170fc4f3d7a0e38e6c5cae09c
Reviewed-on: http://gerrit.cloudera.org:8080/18930
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
be/src/util/jni-util.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/be/src/util/jni-util.cc b/be/src/util/jni-util.cc
index 8792f7863..31dcf6399 100644
--- a/be/src/util/jni-util.cc
+++ b/be/src/util/jni-util.cc
@@ -279,6 +279,8 @@ Status JniUtil::GetJniExceptionMsg(JNIEnv* env, bool log_stack, const string& pr
env->ExceptionClear();
string oom_msg = Substitute(oom_msg_template, "throwableToStackTrace");
LOG(ERROR) << oom_msg;
+ DCHECK(msg_str_guard.get() != nullptr);
+ LOG(ERROR) << msg_str_guard.get();
return Status(oom_msg);
}
JniUtfCharGuard c_stack_guard;