[GitHub] [pulsar] jerrypeng commented on a change in pull request #7211: Have metadata tailer use its own thread for processing

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #7211:
URL: https://github.com/apache/pulsar/pull/7211#discussion_r437590589



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataTopicTailer.java
##########
@@ -69,28 +106,13 @@ public void processRequest(Message<byte[]> msg) {
             serviceRequest = ServiceRequest.parseFrom(msg.getData());
         } catch (IOException e) {
             log.error("Received bad service request at message {}", msg.getMessageId(), e);
-            // TODO: find a better way to handle bad request
-            throw new RuntimeException(e);
+            errorNotifier.triggerError(e);

Review comment:
       Should we just remove the try-catch and let the method throw an exception? Everything is caught in the thread anyways.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org