You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/20 20:35:51 UTC

[GitHub] [netbeans] matthiasblaesing opened a new pull request #1957: Ensure a clean license stub is used for source config builds

matthiasblaesing opened a new pull request #1957: Ensure a clean license stub is used for source config builds
URL: https://github.com/apache/netbeans/pull/1957
 
 
   Before this changeset the LICENSE file from the root of the
   repository/source directory was used to create the LICENSE file of the
   binary build. This worked correctly for the repository because there
   only the ALv2 is present, but a source config build in the LICENSE file
   also the references to the license files for the embedded source files
   with foreign licenses are included.
   
   A binary build from a source config thus contains the license info of
   the source config _and_ the binary build. This is not correct, as the
   binary config can contains less source only files because they are only
   required at build time.
   
   To fix this, a new license-stub.txt is introduced, that only contains
   the ALv2 regardless whether it comes from the repository or from a
   source config build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni commented on issue #1957: Ensure a clean license stub is used for source config builds

Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1957: Ensure a clean license stub is used for source config builds
URL: https://github.com/apache/netbeans/pull/1957#issuecomment-589686005
 
 
   Hi @matthiasblaesing , I'm in the signing process (on my box it's a bit long)
   Is the issue solved on the VC2, the artefacts are here https://builds.apache.org/view/M-R/view/NetBeans/job/netbeans-TLP/job/netbeans/job/release113/20/artifact/dist/netbeans/11.3/vc2/
   
   Would be to know if ok for you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on a change in pull request #1957: Ensure a clean license stub is used for source config builds

Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1957: Ensure a clean license stub is used for source config builds
URL: https://github.com/apache/netbeans/pull/1957#discussion_r382399358
 
 

 ##########
 File path: LICENSE
 ##########
 @@ -201,3 +201,8 @@
    See the License for the specific language governing permissions and
    limitations under the License.
 
+********************************************************************************
+Apache NetBeans repository includes a number of source files that are not
+covered by the apache license. These files are refered to by licenseinfo.xml
 
 Review comment:
   A very, very minor nit.. I believe that apache should be capitalized to be Apache.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on issue #1957: Ensure a clean license stub is used for source config builds

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1957: Ensure a clean license stub is used for source config builds
URL: https://github.com/apache/netbeans/pull/1957#issuecomment-589714960
 
 
   @ebarboni both source and binary look sane to me. Thank you.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jlahoda commented on a change in pull request #1957: Ensure a clean license stub is used for source config builds

Posted by GitBox <gi...@apache.org>.
jlahoda commented on a change in pull request #1957: Ensure a clean license stub is used for source config builds
URL: https://github.com/apache/netbeans/pull/1957#discussion_r382400669
 
 

 ##########
 File path: LICENSE
 ##########
 @@ -201,3 +201,8 @@
    See the License for the specific language governing permissions and
    limitations under the License.
 
+********************************************************************************
+Apache NetBeans repository includes a number of source files that are not
+covered by the apache license. These files are refered to by licenseinfo.xml
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] ebarboni merged pull request #1957: Ensure a clean license stub is used for source config builds

Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1957: Ensure a clean license stub is used for source config builds
URL: https://github.com/apache/netbeans/pull/1957
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists