You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/09 20:22:30 UTC
[GitHub] [fineract] hmg65 opened a new pull request, #2587: FINERACT-1737: Introduce Lombok to smscampaigns module
hmg65 opened a new pull request, #2587:
URL: https://github.com/apache/fineract/pull/2587
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2587: FINERACT-1737: Introduce Lombok to smscampaigns module
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2587:
URL: https://github.com/apache/fineract/pull/2587#discussion_r994494214
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/domain/SmsCampaign.java:
##########
@@ -112,34 +120,8 @@ public class SmsCampaign extends AbstractPersistableCustom {
@Column(name = "is_visible", nullable = true)
private boolean isVisible;
- @Column(name = "is_notification", nullable = true)
- private boolean isNotification;
-
- public SmsCampaign() {}
-
- private SmsCampaign(final String campaignName, final Integer campaignType, final Integer triggerType, final Report businessRuleId,
- final Long providerId, final String paramValue, final String message, final LocalDate submittedOnDate,
- final AppUser submittedBy, final String recurrence, final LocalDateTime localDateTime, final boolean isNotification) {
- this.campaignName = campaignName;
- this.campaignType = campaignType;
- this.triggerType = SmsCampaignTriggerType.fromInt(triggerType).getValue();
- this.businessRuleId = businessRuleId;
- this.providerId = providerId;
- this.paramValue = paramValue;
- this.status = SmsCampaignStatus.PENDING.getValue();
- this.message = message;
- this.submittedOnDate = submittedOnDate;
- this.submittedBy = submittedBy;
- this.recurrence = recurrence;
- LocalDateTime recurrenceStartDate = LocalDateTime.now(DateUtils.getDateTimeZoneOfTenant());
Review Comment:
Logic missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 closed pull request #2587: FINERACT-1737: Introduce Lombok to smscampaigns module
Posted by GitBox <gi...@apache.org>.
hmg65 closed pull request #2587: FINERACT-1737: Introduce Lombok to smscampaigns module
URL: https://github.com/apache/fineract/pull/2587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2587: FINERACT-1737: Introduce Lombok to smscampaigns module
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2587:
URL: https://github.com/apache/fineract/pull/2587#issuecomment-1275948895
@hmg65 can you please do a rebase with the latest develop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2587: FINERACT-1737: Introduce Lombok to smscampaigns module
Posted by GitBox <gi...@apache.org>.
galovics commented on PR #2587:
URL: https://github.com/apache/fineract/pull/2587#issuecomment-1245433068
Build is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org